Update next 14 (#688)

* update next, react, react-dom * update target property in next.config.js * update node version * lint files * lint and remove craCompat * switch to link legacy behavior * lint files * switch to image legacy behavior * fix photo display * update @testing-library/react * install @netlify/plugin-nextjs * remove output in next.config.js * upgrade to node 20 * update @netlify/plugin-nextjs * remove redundant babel config * stop throwing errors on invalid events; warn instead * update lock files * chore: apply missed changes after rebase * chore: switch to link legacy behavior * style: lint files * chore: update @netlify/plugin-nextjs * fix: remove legacyBehavior tag from town hall page * build: change from build to .next * test: add .babelrc to make tests pass * refactor: remove comments * refactor: remove unnecessary redirects file --------- Co-authored-by: Arsh Malik <[email protected]>
uclaacm · Feb 8, 2025 · 67ad98e · 67ad98e
1 parent ba061f6
commit 67ad98e
Show file tree

Hide file tree

Showing 55 changed files with 5,742 additions and 22,429 deletions.
diff --git a/.babelrc b/.babelrc
@@ -1,3 +1,3 @@
 {
   "presets": ["next/babel"]
-}
+}
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -19,7 +19,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [20.x]
 
     env:
       EVENTS_SPREADSHEET_ID: ${{ secrets.EVENTS_SPREADSHEET_ID }}

diff --git a/.github/workflows/node-build.yml b/.github/workflows/node-build.yml
@@ -19,7 +19,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [20.x]
 
     env:
       EVENTS_SPREADSHEET_ID: ${{ secrets.EVENTS_SPREADSHEET_ID }}

diff --git a/.gitignore b/.gitignore
@@ -4,6 +4,7 @@
 /node_modules
 /.pnp
 .pnp.js
+yarn.lock
 
 # testing
 /coverage
@@ -39,3 +40,6 @@ offoutput.json
 townhall.json
 past-townhall.json
 gmData.json
+
+# Local Netlify folder
+.netlify
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-lts/gallium
+lts/iron
diff --git a/_redirects b/_redirects
diff --git a/components/ActiveLink.js b/components/ActiveLink.js
@@ -14,12 +14,12 @@ const ActiveLink = ({ children, activeClassName, ...props }) => {
       : childClassName;
 
   return (
-    //clones child with className if className exists
-    <Link {...props}>
+  //clones child with className if className exists
+    (<Link {...props} legacyBehavior>
       {React.cloneElement(child, {
         className: className || null,
       })}
-    </Link>
+    </Link>)
   );
 };
 

diff --git a/components/Carousel.js b/components/Carousel.js
@@ -1,4 +1,4 @@
-import Image from 'next/image';
+import Image from 'next/legacy/image';
 import React from 'react';
 
 // width of each img in px

diff --git a/components/Committees/CommitteeEventCard.js b/components/Committees/CommitteeEventCard.js
@@ -1,4 +1,4 @@
-import Image from 'next/image';
+import Image from 'next/legacy/image';
 import React from 'react';
 
 function CommitteeEventCard(props) {

diff --git a/components/Committees/CommitteeSectionIntro.js b/components/Committees/CommitteeSectionIntro.js
@@ -8,7 +8,7 @@ import {
 } from '@fortawesome/free-brands-svg-icons';
 import { faLink } from '@fortawesome/free-solid-svg-icons';
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
-import Image from 'next/image';
+import Image from 'next/legacy/image';
 import React from 'react';
 
 function CommitteeIconLink({ committee, link }) {

diff --git a/components/DevProjectCards.js b/components/DevProjectCards.js
@@ -112,7 +112,7 @@ function Project({
 function projects(props) {
   return (
     // TODO: more flexible mobile views
-    <>
+    (<>
       {props.projects.map((project) => (
         <Project
           {...project}
@@ -121,7 +121,7 @@ function projects(props) {
           key={project.name}
         />
       ))}
-    </>
+    </>)
   );
 }
 

diff --git a/components/Events/SelectedEvent.js b/components/Events/SelectedEvent.js
@@ -19,7 +19,7 @@ function SelectedEvent({ event }) {
   }, [event]);
 
   return (
-    <div className={styles['card-container']}>
+    (<div className={styles['card-container']}>
       <h2 className={styles['card-header']}>event information</h2>
       {/* eslint-disable-next-line @next/next/no-img-element */}
       <img
@@ -42,21 +42,21 @@ function SelectedEvent({ event }) {
           <ul className="list-unstyled">
             {links.map(({ text, href, ext }) => (
               <li key={href}>
-                <Link href={href}>
-                  <a
-                    className={styles['event-link']}
-                    target={ext ? '_blank' : ''}
-                    rel={ext ? 'noopener noreferrer' : ''}
-                  >
-                    {text}
-                  </a>
+                <Link
+                  href={href}
+                  className={styles['event-link']}
+                  target={ext ? '_blank' : ''}
+                  rel={ext ? 'noopener noreferrer' : ''}>
+
+                  {text}
+
                 </Link>
               </li>
             ))}
           </ul>
         )}
       </div>
-    </div>
+    </div>)
   );
 }
 

diff --git a/components/Footer.js b/components/Footer.js
@@ -1,8 +1,8 @@
 import Link from 'next/link';
 import React from 'react';
+import SocialMedia from './SocialMedia';
 import committees from '../data/committees';
 import styles from '../styles/components/Footer.module.scss';
-import SocialMedia from './SocialMedia';
 
 const footerACMLinks = [
   { title: 'About', path: '/about' },
@@ -27,21 +27,21 @@ const footerInitiativeLinks = [
 
 function FooterLinkElement({ title, path, ext }) {
   return (
-    <Link href={path}>
-      <a
-        className={styles['link-footer']}
-        target={ext ? '_blank' : ''}
-        rel={ext ? 'noopener noreferrer' : ''}
-      >
-        {title}
-      </a>
-    </Link>
+    (<Link
+      href={path}
+      className={styles['link-footer']}
+      target={ext ? '_blank' : ''}
+      rel={ext ? 'noopener noreferrer' : ''}>
+
+      {title}
+
+    </Link>)
   );
 }
 
 function Footer() {
   return (
-    <footer className={styles.footer}>
+    (<footer className={styles.footer}>
       <nav
         className={styles['footer-inner']}
         aria-labelledby="footer-navigation"
@@ -54,25 +54,25 @@ function Footer() {
             <h3 className={styles['footer-header']}>Find us on social media</h3>
             <SocialMedia type="light" />
             <div className="mt-1">
-              <Link href="http://eepurl.com/hdEvNP">
-                <a
-                  className="button tight"
-                  target="_blank"
-                  rel="noreferrer noopener"
-                >
+              <Link
+                href="http://eepurl.com/hdEvNP"
+                className="button tight"
+                target="_blank"
+                rel="noreferrer noopener">
+
                   Join our Mailing List
-                </a>
+
               </Link>
             </div>
             <div className="mt-1">
-              <Link href="https://linktr.ee/acmucla">
-                <a
-                  className="button tight"
-                  target="_blank"
-                  rel="noreferrer noopener"
-                >
+              <Link
+                href="https://linktr.ee/acmucla"
+                className="button tight"
+                target="_blank"
+                rel="noreferrer noopener">
+
                   Linktree
-                </a>
+
               </Link>
             </div>
             <p className={styles['footer-header']}>Reach us at</p>
@@ -151,7 +151,7 @@ function Footer() {
           </span>
         </div>
       </nav>
-    </footer>
+    </footer>)
   );
 }
 

diff --git a/components/Impact/BlogCard.js b/components/Impact/BlogCard.js
@@ -22,30 +22,30 @@ export default function BlogCard({
     // TODO: not sure how, but we need to semantically
     // insert a description of the image for screenreaders;
     // not natively supported by background-image
-    <Link href={href}>
-      <a
-        target="_blank"
-        className={styles['blog-card']}
-        style={backgroundStyle}
-      >
-        <div className={styles['blog-card-content']}>
-          <h4 className={styles['blog-title']}>{title}</h4>
-          <p className={styles['blog-info']}>
-            {/* eslint-disable-next-line @next/next/no-img-element */}
-            <img
-              className={styles['blog-author-img']}
-              src={authorImg}
-              alt={authorAlt}
-            />
-            <div>
-              {author}
-              <br />
-              {/* TODO: moment for date? */}
-              {date} • {length}
-            </div>
-          </p>
-        </div>
-      </a>
-    </Link>
+    (<Link
+      href={href}
+      target="_blank"
+      className={styles['blog-card']}
+      style={backgroundStyle}>
+
+      <div className={styles['blog-card-content']}>
+        <h4 className={styles['blog-title']}>{title}</h4>
+        <p className={styles['blog-info']}>
+          {/* eslint-disable-next-line @next/next/no-img-element */}
+          <img
+            className={styles['blog-author-img']}
+            src={authorImg}
+            alt={authorAlt}
+          />
+          <div>
+            {author}
+            <br />
+            {/* TODO: moment for date? */}
+            {date} • {length}
+          </div>
+        </p>
+      </div>
+
+    </Link>)
   );
 }
diff --git a/components/Impact/Carousel.js b/components/Impact/Carousel.js
@@ -1,9 +1,9 @@
 import React, { useState, useEffect } from 'react';
 
+import BlogCard from './BlogCard';
 import { blogs } from '../../data/impact';
 import styles from '../../styles/pages/impact.module.scss';
 
-import BlogCard from './BlogCard';
 
 function Carousel() {
   const [activeItem, changeActiveItem] = useState(0); // keeps track of blog index (0, 1, or 2) that is currently active

diff --git a/components/Impact/WorkshopCard.js b/components/Impact/WorkshopCard.js
@@ -1,4 +1,4 @@
-import Image from 'next/image';
+import Image from 'next/legacy/image';
 import React from 'react';
 
 import styles from '../../styles/pages/impact.module.scss';

diff --git a/components/Internship/CommitteeInternshipInfo.js b/components/Internship/CommitteeInternshipInfo.js
@@ -1,4 +1,4 @@
-import Image from 'next/image';
+import Image from 'next/legacy/image';
 import React, { useState } from 'react';
 
 import styles from '../../styles/components/Internship/CommitteeInternshipInfo.module.scss';

diff --git a/components/Internship/NextSteps.js b/components/Internship/NextSteps.js
@@ -3,20 +3,6 @@ import React from 'react';
 function NextSteps(props) {
   const { image, name, info } = props;
   return (
-    <>
-      <div
-        style={{
-          border: '1px solid grey',
-          margin: '5px',
-          borderRadius: '5px',
-          padding: '15px',
-        }}
-      >
-        {/* eslint-disable-next-line @next/next/no-img-element */}
-        <img src={image} alt={name} height="30px" />
-        <p>{info}</p>
-      </div>
-    </>
     // <button className={styles['committee-card']} onClick={() => setFlipped(!isFlipped)} role='tab'>
     //     <div className={`${styles['next-steps-card-inner']} ${styles[isFlipped ? null : 'is-flipped']}`}>
     //         <div className={styles['next-steps-card-face']}>
@@ -32,6 +18,20 @@ function NextSteps(props) {
     //         </div>
     //     </div>
     // </button>
+    (<>
+      <div
+        style={{
+          border: '1px solid grey',
+          margin: '5px',
+          borderRadius: '5px',
+          padding: '15px',
+        }}
+      >
+        {/* eslint-disable-next-line @next/next/no-img-element */}
+        <img src={image} alt={name} height="30px" />
+        <p>{info}</p>
+      </div>
+    </>)
   );
 }
 

diff --git a/components/JEDI/AllyshipSpaceCard.js b/components/JEDI/AllyshipSpaceCard.js
@@ -1,4 +1,4 @@
-import Image from 'next/image';
+import Image from 'next/legacy/image';
 import Link from 'next/link';
 import React from 'react';
 
@@ -22,7 +22,7 @@ function AllyshipSpaceCard({
   priority,
 }) {
   return (
-    <div className={`${styles['allyship-row']} ${styles['mb-2']}`}>
+    (<div className={`${styles['allyship-row']} ${styles['mb-2']}`}>
       <div className={styles['allyship-image']}>
         <Image src={img} alt={alt} priority={priority} />
       </div>
@@ -31,15 +31,15 @@ function AllyshipSpaceCard({
         {/* wrapped in a fragment to allow for spacing */}
         {rsvp && (
           <>
-            <Link href={rsvp}>
-              <a className={styles['jedi-link']}>RSVP</a>
+            <Link href={rsvp} className={styles['jedi-link']}>
+              RSVP
             </Link>{' '}
           </>
         )}
         {slides && (
           <>
-            <Link href={slides}>
-              <a className={styles['jedi-link']}>Slides</a>
+            <Link href={slides} className={styles['jedi-link']}>
+              Slides
             </Link>{' '}
           </>
         )}
@@ -53,7 +53,7 @@ function AllyshipSpaceCard({
         </p>
         <p className={styles['my-tight']}>{description}</p>
       </div>
-    </div>
+    </div>)
   );
 }