CTP-3973 correct cache clear

ucl-isd · Oct 29, 2024 · 5f1eb38 · 5f1eb38
1 parent 1b81320
commit 5f1eb38
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/classes/controllers/feedback_controller.php b/classes/controllers/feedback_controller.php
@@ -371,6 +371,10 @@ protected function update_feedback() {
 
             } else {
                 $teacherfeedback->destroy();
+                // Clear cache.
+                \mod_coursework\models\feedback::remove_cache($this->submission->courseworkid);
+                \mod_coursework\models\submission::remove_cache($this->submission->courseworkid);
+
                 // Remove associated files
                 $fs = get_file_storage();
                 $fs->delete_area_files($teacherfeedback->get_coursework()->get_context()->id, 'mod_coursework', 'feedback', $teacherfeedback->id());

diff --git a/classes/framework/table_base.php b/classes/framework/table_base.php
@@ -456,9 +456,6 @@ public function destroy() {
         $this->before_destroy();
 
         $DB->delete_records(static::get_table_name(), ['id' => $this->id]);
-        // Clear cache.
-        \mod_coursework\models\feedback::remove_cache($this->submission->courseworkid);
-        \mod_coursework\models\submission::remove_cache($this->submission->courseworkid);
     }
 
     /**