8.2 to 8.4 upgrade #978
Merged
8.2 to 8.4 upgrade #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbed
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Great work getting the upgrade to work, I knew you could do it :-)
I've been testing the changes and it seems like the user side is good, I couldn't really find anything that didn't work at least. As far as I can see, I think we're fine to merge this into dev. I've also been already using these changes in the equal-access branch and I haven't ran into any issues either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes that allow UDOIT to work with PHP 8.4 instead of 8.2, which no longer has active support, as of last December (read here for more details).
Please let me know if issues come up running this branch. Due to the sheer volume of changes between the 8.2 branches and this one, you may have to clear the cache and run the following commands to have UDOIT load properly.
Before running the containers:
rm composer.lockrm -rf vendordocker compose -f docker-compose.nginx.yml run composer composer clear-cacheand finally:
docker compose -f docker-compose.nginx.yml run composer composer installto reinstall the necessary packagesThen run the containers from scratch using:
docker compose -f docker-compose.nginx.yml up --build