-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ux:Add GNOME-style type to search function to find apps faster #1890
base: main
Are you sure you want to change the base?
Conversation
Hey! IldySilva has not signed the Canonical CLA which is required to get this contribution merged on this project.
Please head over to https://ubuntu.com/legal/contributors to read more about it. |
@Feichtmeier can you take a look? |
HI @IldySilva, thanks for your work. I need to forward this to @d-loose as I am not leading this project here anymore :) |
@d-loose can you check it? |
Hey, thanks for your contribution. In principle I'm not opposed to focus the search bar when the user starts typing instead of having to use ctrl+f (@anasereijo, @juanruitina what do you think?). However, we'd need to be about more careful about capturing keyboard events - in its current state, this PR breaks the search field on the manage page as well as the 'report' dialog. |
I Understand, @d-loose Could you please tell me how to reproduce this break? |
Screencast.From.2025-01-29.14-19-49.webm |
@d-loose i will certainly pay more attention when doing this type of implementation. For now, I will correct this point. |
references the #1880