Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux:Add GNOME-style type to search function to find apps faster #1890

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

IldySilva
Copy link

references the #1880

  1. Adding the feature and the test

Copy link

Hey! IldySilva has not signed the Canonical CLA which is required to get this contribution merged on this project.

Please head over to https://ubuntu.com/legal/contributors to read more about it.

@IldySilva
Copy link
Author

@Feichtmeier can you take a look?

@Feichtmeier
Copy link
Member

HI @IldySilva, thanks for your work. I need to forward this to @d-loose as I am not leading this project here anymore :)

@IldySilva
Copy link
Author

IldySilva commented Jan 29, 2025

@d-loose can you check it?

@d-loose
Copy link
Member

d-loose commented Jan 29, 2025

Hey, thanks for your contribution. In principle I'm not opposed to focus the search bar when the user starts typing instead of having to use ctrl+f (@anasereijo, @juanruitina what do you think?). However, we'd need to be about more careful about capturing keyboard events - in its current state, this PR breaks the search field on the manage page as well as the 'report' dialog.

@IldySilva
Copy link
Author

I Understand, @d-loose Could you please tell me how to reproduce this break?
I just saw it at some point while typing in 'report' and 'manager', but I can't reproduce it on purpose.

@d-loose
Copy link
Member

d-loose commented Jan 29, 2025

Screencast.From.2025-01-29.14-19-49.webm

@IldySilva
Copy link
Author

@d-loose i will certainly pay more attention when doing this type of implementation. For now, I will correct this point.
thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants