feat: make use of snap_name in server replies
#1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-loose
force-pushed
the
use-snap-names
branch
from
c18afd1 to
803861f
Compare
This removes the deprecated `ListMyVotes` method and adds `snap_name` fields to the `Rating` and `Vote` messages
d-loose
force-pushed
the
use-snap-names
branch
from
803861f to
5f49e9d
Compare
sminez
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to ubuntu/app-center-ratings#153
Uses the
snap_namefield added toRatingandVoteserver-side, which eliminates the need to resolvesnap_ids intosnap_names in the app-center.Since this needs a regeneration of the protobuf files, I've also removed the
listMyVotesmethods following ubuntu/app-center-ratings#151.UDENG-5628