Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: update to core24 #1749

Merged
merged 1 commit into from
Sep 20, 2024
Merged

snap: update to core24 #1749

merged 1 commit into from
Sep 20, 2024

Conversation

jssotomdz
Copy link
Collaborator

this pull request migrates the app center to core24
migration seems very straightforward only requiring the change in the base parameter and adding git as build parameter (how did it get it before by the way?)

@jssotomdz jssotomdz requested a review from d-loose July 18, 2024 20:17
@d-loose
Copy link
Member

d-loose commented Jul 22, 2024

this pull request migrates the app center to core24 migration seems very straightforward only requiring the change in the base parameter and adding git as build parameter (how did it get it before by the way?)

Hm interesting, it wasn't needed for core22, I don't know why though. Maybe @kenvandine knows

Copy link
Member

@d-loose d-loose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kenvandine
Copy link
Member

this pull request migrates the app center to core24 migration seems very straightforward only requiring the change in the base parameter and adding git as build parameter (how did it get it before by the way?)

Hm interesting, it wasn't needed for core22, I don't know why though. Maybe @kenvandine knows

Sounds like a snapcraft bug. Snapcraft included git as a build-package when sources came from git automatically.

@d-loose
Copy link
Member

d-loose commented Jul 23, 2024

Sounds like a snapcraft bug. Snapcraft included git as a build-package when sources came from git automatically.

The source-type isn't set here, so maybe something changed in the detection mechanism?

@MrSIHAB
Copy link
Contributor

MrSIHAB commented Aug 18, 2024

this pull request migrates the app center to core24 migration seems very straightforward only requiring the change in the base parameter and adding git as build parameter (how did it get it before by the way?)

Hm interesting, it wasn't needed for core22, I don't know why though. Maybe @kenvandine knows

actually it was built on ubuntu 22.04 and probably core 24 hadn't that much dependency or plugin then.

@d-loose d-loose merged commit 8a00331 into ubuntu:main Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants