-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom error view #1723
Conversation
Updated error pages matching the Figma designs: Server error (e.g. 'too many requests') 'Retry' will retry the action prior to encountering the error (loading search results, displaying a snap page, ..). 'Check status' will open https://status.snapcraft.io/ in a browser. |
- add `ErrorMessage` structure for localized error title, body and actions - add retry logic where possible - link to snapcraft status page for server errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm functionality-wise!
I'm sure Ana will want to have a say in the design for the generic ones later. 😄
I've double-checked Figma now and realized that I forgot to actually include the action texts for each error in the view. Added them now and updated the screenshots in my previous comment! @anasereijo please have a quick look when you have some time :) |
Imho a centered, vertical layout could be better, especially for when the window size varies
|
I agree, it feels a bit "off" now, let's check that with Ana :) |
+1 for centered layout 👍
Obviously, us mortals can't see the Figma mockups, but shouldn't the "headline" have a different styling? I know that it is slightly larger, but it's barely visible and doesn't feel like a propper heading. Maybe just use the same weight as we use on the Update page? |
It does indeed look better centered 👍 The spacing between elements looks odd - the first line of text looks closer to the heading than to the second line of text. I suggest adding more padding between the heading and the text, and decrease (or remove) the padding between the two lines of text. |
@anasereijo we can go over design and copy for all of those next week:
Error message when refreshing a single snap or switching the channel while it is running:
Generic error page with custom message for
SnapdException(kind: 'network-timeout')
(see #1479 and #1668)Generic error page with custom message for
SnapdException(message: 'too many requests')
(see #1684)Ref #1479, #1668, #1684
UDENG-3056
UDENG-3264