feat: ctrl+f shortcut to focus search field #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jssotomdz, Don't hesitate to reach if you have any issue. |
BLKKKBVSIK
approved these changes
Jan 17, 2024
ashuntu
pushed a commit
to ashuntu/app-center
that referenced
this pull request
Feb 28, 2024
feat: ctrl+f shortcut to focus search field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a keyboard shortcut to focus the search text field by clicking ctrl+f
For some reason the formatting (indenting) destroys the diff look. And kind of makes sense because I made the
YaruThemea child of theCallbackShortcuts. Is there a formatting helper or a guide for this? I could push directly to this branch to fix these code formatting issues if neededAlso, unit tests are failing because I changed the SearchField constructor signature so I have to rewrite the unit tests for them to succeed. I can do that in a separate commit if you're ok with it.