-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: manage page - Individual update buttons #1538
Conversation
Hi @codinesh ! Great work !
|
Hello @BLKKKBVSIK, thanks for reviewing the PR. Reverted the changes made to pubspec.yaml, that change was not intended to push, it was in my local only.
Please let me know if I can do anything for icon change. |
Everyone contributing to this PR have now signed the CLA. Thanks! |
Hey @codinesh, |
Hello @BLKKKBVSIK, I have signed the CLA, can you please retrigger the checks if possible. |
I just retriggered it, and I have the same result. |
thank you. I have signed a week back with [email protected] as contact. Other PR CLA check ran successfully at that time. I have agreed to CLA again now, hope it will be resolved, please let me know if there is anything else I can do. Thanks. |
@codinesh you have to do two things for the CLA to pass:
|
393024b
to
c553d86
Compare
Hello @spydon, thank you for the instructions. I have amended the commit with correct author email. |
Hello @spydon, thank you for the instructions. I have ammended the commit with correct author email. |
Good stuff, now it passes! |
Hello @spydon, @BLKKKBVSIK - Please let me know if there is any action on this from my end to merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, just two minor comments
Hi @codinesh thanks for your help!
You are correct. When the 'update all' button is clicked, the individual update buttons will be disabled, but also showing the loading status. See screenshot below: |
feat: manage page - Individual update buttons
Fixes #1532 by adding update button for each snap under updates section.
Hello @BLKKKBVSIK, @anasereijo, since this is similar to #1533, I have created this PR, please help with review.