Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manage page - Individual update buttons #1538

Merged
merged 9 commits into from
Dec 28, 2023

Conversation

codinesh
Copy link
Contributor

Fixes #1532 by adding update button for each snap under updates section.

image

Hello @BLKKKBVSIK, @anasereijo, since this is similar to #1533, I have created this PR, please help with review.

  1. When update all is clicked, individual snap update buttons will be disabled. This seems like different from Figma. Will make the change to match with figma if needed.

@BLKKKBVSIK BLKKKBVSIK changed the title Manage page: Individual update buttons feat: manage page - Individual update buttons Dec 17, 2023
@BLKKKBVSIK
Copy link
Collaborator

Hi @codinesh !

Great work !
Finally, has some time to review your PR:

  • The update icons aren't matching with what was planned in intern (I'll investigate that tomorrow, and add it to your PR)
  • I don't think that any of the modification you made to the pubspec.yaml were necessary. Could you revert that?

@codinesh
Copy link
Contributor Author

codinesh commented Dec 18, 2023

Hello @BLKKKBVSIK, thanks for reviewing the PR.

Reverted the changes made to pubspec.yaml, that change was not intended to push, it was in my local only.

The update icons aren't matching with what was planned in intern (I'll investigate that tomorrow, and add it to your PR)

Please let me know if I can do anything for icon change.

Copy link

github-actions bot commented Dec 20, 2023

Everyone contributing to this PR have now signed the CLA. Thanks!

@BLKKKBVSIK
Copy link
Collaborator

Hey @codinesh,
For your PR to be tested and potentially merged, we need you to sign the CLA.
You can add @tim-hm ([email protected]) as a contact, when signing the CLA.

@codinesh
Copy link
Contributor Author

You can add @Tim-H

Hello @BLKKKBVSIK, I have signed the CLA, can you please retrigger the checks if possible.

@BLKKKBVSIK
Copy link
Collaborator

I just retriggered it, and I have the same result.
Will check what I can do. Otherwise, it will have to wait until January.

@codinesh
Copy link
Contributor Author

I just retriggered it, and I have the same result. Will check what I can do. Otherwise, it will have to wait until January.

thank you. I have signed a week back with [email protected] as contact. Other PR CLA check ran successfully at that time.

I have agreed to CLA again now, hope it will be resolved, please let me know if there is anything else I can do. Thanks.

@spydon
Copy link
Collaborator

spydon commented Dec 22, 2023

@codinesh you have to do two things for the CLA to pass:

  1. Set your primary github e-mail to the one that you signed the CLA with (if you want to be able to do web based git interactions, like updating the branch), check here how to do that: https://docs.github.com/en/github-ae@latest/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address

  2. Change the e-mail of previous commits (luckily just the last one) that have the wrong e-mail ([email protected]):

git commit --amend --author="Dinesh <[email protected]>"
git push -f

@codinesh codinesh force-pushed the managepage-update-snap branch from 393024b to c553d86 Compare December 24, 2023 06:08
@codinesh
Copy link
Contributor Author

@codinesh you have to do two things for the CLA to pass:

  1. Set your primary github e-mail to the one that you signed the CLA with (if you want to be able to do web based git interactions, like updating the branch), check here how to do that: https://docs.github.com/en/github-ae@latest/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address
  2. Change the e-mail of previous commits (luckily just the last one) that have the wrong e-mail ([email protected]):
git commit --amend --author="Dinesh <[email protected]>"
git push -f

Hello @spydon, thank you for the instructions. I have amended the commit with correct author email.

@codinesh
Copy link
Contributor Author

@codinesh you have to do two things for the CLA to pass:

  1. Set your primary github e-mail to the one that you signed the CLA with (if you want to be able to do web based git interactions, like updating the branch), check here how to do that: https://docs.github.com/en/github-ae@latest/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address
  2. Change the e-mail of previous commits (luckily just the last one) that have the wrong e-mail ([email protected]):
git commit --amend --author="Dinesh <[email protected]>"
git push -f

Hello @spydon, thank you for the instructions. I have ammended the commit with correct author email.

@spydon
Copy link
Collaborator

spydon commented Dec 24, 2023

Hello @spydon, thank you for the instructions. I have ammended the commit with correct author email.

Good stuff, now it passes!
I think we can review and merge this on Tuesday when we're back to work.

@codinesh
Copy link
Contributor Author

Hello @spydon, @BLKKKBVSIK - Please let me know if there is any action on this from my end to merge this PR?

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just two minor comments

packages/app_center/lib/src/manage/manage_page.dart Outdated Show resolved Hide resolved
packages/app_center/pubspec.yaml Outdated Show resolved Hide resolved
@BLKKKBVSIK BLKKKBVSIK merged commit 510a4d9 into ubuntu:main Dec 28, 2023
8 checks passed
@codinesh codinesh deleted the managepage-update-snap branch December 28, 2023 16:35
@anasereijo
Copy link
Collaborator

Hi @codinesh thanks for your help!

When update all is clicked, individual snap update buttons will be disabled. This seems like different from Figma. Will make the change to match with figma if needed.

You are correct. When the 'update all' button is clicked, the individual update buttons will be disabled, but also showing the loading status. See screenshot below:

Screenshot 2024-01-02 at 14 05 19

ashuntu pushed a commit to ashuntu/app-center that referenced this pull request Feb 28, 2024
feat: manage page - Individual update buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manage page: add individual update buttons
4 participants