-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show "App Center" in Gnome Shell activities view #1534
Show "App Center" in Gnome Shell activities view #1534
Conversation
Looks good to me, however I am not an app-center developer. :-) |
Agh! :-D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sergio-costas LGTM 👍
I've pinned the mockito version, like we do in the provision monorepo.
@d-loose Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In hindsight, it might be cleaner to do this in Flutter instead of further customizing the GTK application. With this change, we could change the title from within Flutter using |
As you prefer. Certainly, simplifying the C part is a good idea. |
Just published yaru_window 0.2.0 with @Feichtmeier's help :) |
5830b6d
to
4cd4ba7
Compare
…gnome-shell-activities-view Show "App Center" in Gnome Shell activities view
Currently, the window in the Activities view in Gnome Shell has "snap-store" as its name, which is incorrect because this is the brand-new "App Center". The reason is that the Activities view shows the window title, but the app center doesn't set it, so it is set to the binary name.
The patch uses the translations from the .desktop file, thus it doesn't require extra effort to ensure that the name shown in the Activities view is correctly translated.
fix #1425