Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "App Center" in Gnome Shell activities view #1534

Conversation

sergio-costas
Copy link
Contributor

@sergio-costas sergio-costas commented Dec 13, 2023

Currently, the window in the Activities view in Gnome Shell has "snap-store" as its name, which is incorrect because this is the brand-new "App Center". The reason is that the Activities view shows the window title, but the app center doesn't set it, so it is set to the binary name.

The patch uses the translations from the .desktop file, thus it doesn't require extra effort to ensure that the name shown in the Activities view is correctly translated.

fix #1425

@AsciiWolf
Copy link
Contributor

Looks good to me, however I am not an app-center developer. :-)

@sergio-costas
Copy link
Contributor Author

Agh! :-D

Copy link
Member

@d-loose d-loose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergio-costas LGTM 👍

I've pinned the mockito version, like we do in the provision monorepo.

@sergio-costas
Copy link
Contributor Author

@d-loose Thanks!

Copy link
Contributor

@AsciiWolf AsciiWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-loose
Copy link
Member

d-loose commented Dec 15, 2023

In hindsight, it might be cleaner to do this in Flutter instead of further customizing the GTK application. With this change, we could change the title from within Flutter using YaruWindow.of(context).setTitle(..) and simply add 'App Center' to the l10n strings. What do you think?

@sergio-costas
Copy link
Contributor Author

As you prefer. Certainly, simplifying the C part is a good idea.

@d-loose
Copy link
Member

d-loose commented Dec 15, 2023

Just published yaru_window 0.2.0 with @Feichtmeier's help :)
@BLKKKBVSIK, if you find some time to implement a Flutter-based version of this fixed, as explained above, that'd be awesome!
I'm off for the remainder of the year now :)
Happy holidays everyone!

@BLKKKBVSIK BLKKKBVSIK force-pushed the fix-window-name-in-gnome-shell-activities-view branch from 5830b6d to 4cd4ba7 Compare December 27, 2023 10:26
@BLKKKBVSIK BLKKKBVSIK requested a review from spydon December 27, 2023 10:27
@BLKKKBVSIK BLKKKBVSIK merged commit ac6798b into ubuntu:main Dec 27, 2023
8 checks passed
ashuntu pushed a commit to ashuntu/app-center that referenced this pull request Feb 28, 2024
…gnome-shell-activities-view

Show "App Center" in Gnome Shell activities view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The app name is App Center but shows snap-store in overview
5 participants