feat: adding a snackbar for feedback on the share button #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-loose
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
We should really have a better way to access the Navigator or Scaffold of the yaru layout widgets. But that's probably the cleanest solution for now - LGTM 👍
@Feichtmeier FYI
|
Just to double-check, is this the style (and position) we use for snackbars on yaru? |
|
Style yes, we tried to be consistent with yaru GNOME (you can see this in the file manager application "nautilus"/"files" on ubuntu) |
ashuntu
pushed a commit
to ashuntu/app-center
that referenced
this pull request
Feb 28, 2024
…-button feat: adding a snackbar for feedback on the share button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
fix #1462
Screencast.from.2023-12-11.16-16-07.webm