Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plural spelling issue for l10n #1511

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

BLKKKBVSIK
Copy link
Collaborator

@BLKKKBVSIK BLKKKBVSIK commented Nov 29, 2023

In this PR:

  • Adding plural for l10n.

fix #1451

Ex:
Now:
Screenshot from 2023-11-29 10-43-57
Before:
Screenshot from 2023-11-29 10-44-19

@BLKKKBVSIK BLKKKBVSIK requested review from d-loose and spydon November 29, 2023 09:56
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually wrong, nouns following zero should (confusingly) be treated as plural.
https://english.stackexchange.com/questions/38293/why-is-zero-followed-by-a-plural-noun

@BLKKKBVSIK
Copy link
Collaborator Author

I made this error for half of my life then ! 😅
I learned something (not code related) with this PR ;)

@BLKKKBVSIK BLKKKBVSIK merged commit 567d8f7 into main Nov 29, 2023
8 checks passed
@BLKKKBVSIK BLKKKBVSIK deleted the fix/plurial_spelling_about_page branch November 29, 2023 12:44
@fthx
Copy link
Contributor

fthx commented Nov 29, 2023

That's not the case in French.
We write:
0 jour
1 jour
2 jours
...

@spydon
Copy link
Collaborator

spydon commented Nov 29, 2023

That's not the case in French. We write: 0 jour 1 jour 2 jours ...

Google translate tells me that the current translation is correct for 0 in French already, but I don't speak French:

"managePageUpdatedDaysAgo": "Mis à jour il y a {n} jours",

https://github.com/ubuntu/app-center/blob/main/packages/app_center/lib/src/l10n/app_fr.arb#L164C32-L164C59

@fthx
Copy link
Contributor

fthx commented Nov 29, 2023

No this translation is not correct.
That's the point of this BR.

@spydon
Copy link
Collaborator

spydon commented Nov 29, 2023

No this translation is not correct. That's the point of this BR.

The PR you are currently commenting on is for English, so I don't really get what you mean.
The French one seems to be wrong for 1 (which is probably the case for most languages), but not for 0 as your initial comment suggested.

@spydon
Copy link
Collaborator

spydon commented Nov 29, 2023

Aah now I get it #1451 was supposed to be for French? Didn't notice since that sentence was still in English on your screenshot.

@fthx
Copy link
Contributor

fthx commented Nov 29, 2023

The FR one is wrong for 0 too.
https://dictionnaire.lerobert.com/guide/accord-du-nom-apres-zero

In FR we write:
« I made no errors in my code. »
(because usually there are many)
but
« I made zero error in my code.»

ashuntu pushed a commit to ashuntu/app-center that referenced this pull request Feb 28, 2024
…_page

fix: plural spelling issue for l10n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 day, 2 days in Manage list
3 participants