Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change Github to GitHub #1489

Merged
merged 3 commits into from
Nov 28, 2023
Merged

docs: Change Github to GitHub #1489

merged 3 commits into from
Nov 28, 2023

Conversation

jbampton
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 13, 2023

Everyone contributing to this PR have now signed the CLA. Thanks!

@spydon
Copy link
Collaborator

spydon commented Nov 24, 2023

@jbampton if you sign the CLA I can merge this, otherwise I'll close it and fix up the typo separately. :)

@jbampton
Copy link
Contributor Author

Hey @spydon I have signed the agreement with my email jbampton@gmail.com but the CLA still fails

@spydon
Copy link
Collaborator

spydon commented Nov 25, 2023

Hey @spydon I have signed the agreement with my email jbampton@gmail.com but the CLA still fails

Ah, I think the commit isn't connected to that email?

https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#setting-your-commit-email-address-in-git

@jbampton
Copy link
Contributor Author

I'm using the GitHub-provided noreply email address on GitHub

@spydon
Copy link
Collaborator

spydon commented Nov 25, 2023

I'm using the GitHub-provided noreply email address on GitHub

Yeah, you have to change the e-mail of the commit to the one that you signed the cla with.

This should be enough:

git commit --amend --author="author_name <email>" --no-edit
git push -f

@spydon
Copy link
Collaborator

spydon commented Nov 25, 2023

You don't seem to have a launchpad account connected to that email?

@jbampton
Copy link
Contributor Author

https://launchpad.net/~johnbam

Seems it is not picking up the account

@spydon spydon changed the title Fix spelling: change Github to GitHub docs: Change Github to GitHub Nov 28, 2023
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the most effort I have ever put into a one word PR 😅

@spydon spydon merged commit ecee8bb into ubuntu:main Nov 28, 2023
8 checks passed
@jbampton jbampton deleted the fix-spelling branch November 28, 2023 17:04
@jbampton
Copy link
Contributor Author

Thank you @spydon well done 💯

ashuntu pushed a commit to ashuntu/app-center that referenced this pull request Feb 28, 2024
docs: Change `Github` to `GitHub`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants