Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packagekit): check arch compatibility in resolve #1486

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Nov 8, 2023

Fix #1485

  • reads the local architecture from the snap environment (or from the output of dpkg --print-architecture)
  • makes sure resolve() only returns packages with matching architecture

Adding proper support for foreign architectures requires a bit more care and some UI/UX input - I'd leave that as a separate issue.

Copy link
Collaborator

@matthew-hagemann matthew-hagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@d-loose d-loose merged commit fb7779d into ubuntu:main Nov 10, 2023
8 checks passed
@d-loose d-loose deleted the arch-compatibility branch November 10, 2023 12:02
ashuntu pushed a commit to ashuntu/app-center that referenced this pull request Feb 28, 2024
fix(packagekit): check arch compatibility in resolve
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If multiarch is enabled, deb packages for foreign architectures are installed without a warning
2 participants