Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Height of search fields should be static #1833

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

spydon
Copy link
Collaborator

@spydon spydon commented Oct 4, 2024

Screencast.from.2024-10-04.16-31-39.webm

Fixes: #1832

Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
I think it's also used in the manage page does the height still fit now?

@spydon
Copy link
Collaborator Author

spydon commented Oct 4, 2024

Lgtm I think it's also used in the manage page does the height still fit now?

That's why I showed the manage page search bar in the video too 😄

@anasereijo
Copy link
Collaborator

maybe it's the video recording, but the focused outline (orange) isn't rendering well?

Screenshot 2024-10-04 at 15 48 36

@spydon
Copy link
Collaborator Author

spydon commented Oct 4, 2024

maybe it's the video recording, but the focused outline (orange) isn't rendering well?
Screenshot 2024-10-04 at 15 48 36

It's just the video, no idea why it became such low quality when I uploaded it here.

@anasereijo
Copy link
Collaborator

Hmmm I approved the changes but didn't look at the code! 😄

@Feichtmeier
Copy link
Member

Lgtm I think it's also used in the manage page does the height still fit now?

That's why I showed the manage page search bar in the video too 😄

Woops ... Right 👍 sorry

@spydon spydon merged commit c0b4a3e into main Oct 7, 2024
8 checks passed
@spydon spydon deleted the fix/search-field-static-height branch October 7, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search field jumps in height when it is not empty
4 participants