fix: Height of search fields should be static (#1833)

[Screencast from 2024-10-04 16-31-39.webm](https://github.com/user-attachments/assets/85998e6a-e416-46af-a10a-7d745a5e9f0d) Fixes: #1832
ubuntu · Oct 7, 2024 · c0b4a3e · c0b4a3e
1 parent 6d89565
commit c0b4a3e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/app_center/lib/constants.dart b/packages/app_center/lib/constants.dart
@@ -18,5 +18,5 @@ const kSearchFieldIconConstraints = BoxConstraints(
   maxWidth: 32,
   maxHeight: 32,
 );
-const kSearchFieldStrutStyle = StrutStyle(leading: 0.2);
+const kSearchFieldContentPadding = EdgeInsets.all(12);
 const kSearchFieldPrefixIcon = Icon(YaruIcons.search, size: 16);
diff --git a/packages/app_center/lib/manage/manage_page.dart b/packages/app_center/lib/manage/manage_page.dart
@@ -179,10 +179,11 @@ class ManagePage extends ConsumerWidget {
                     // here and the `SearchField` widget
                     child: TextFormField(
                       style: Theme.of(context).textTheme.bodyMedium,
-                      strutStyle: kSearchFieldStrutStyle,
                       textAlignVertical: TextAlignVertical.center,
                       cursorWidth: 1,
                       decoration: InputDecoration(
+                        isDense: true,
+                        contentPadding: kSearchFieldContentPadding,
                         prefixIcon: kSearchFieldPrefixIcon,
                         prefixIconConstraints: kSearchFieldIconConstraints,
                         hintText: l10n.managePageSearchFieldSearchHint,

diff --git a/packages/app_center/lib/search/search_field.dart b/packages/app_center/lib/search/search_field.dart
@@ -168,7 +168,6 @@ class _SearchFieldState extends ConsumerState<SearchField> {
 
               return TextField(
                 style: Theme.of(context).textTheme.bodyMedium,
-                strutStyle: kSearchFieldStrutStyle,
                 textAlignVertical: TextAlignVertical.center,
                 cursorWidth: 1,
                 focusNode: node,
@@ -178,7 +177,8 @@ class _SearchFieldState extends ConsumerState<SearchField> {
                     ? onFieldSubmitted()
                     : widget.onSearch(query),
                 decoration: InputDecoration(
-                  contentPadding: const EdgeInsets.fromLTRB(12, 8, 12, 8),
+                  isDense: true,
+                  contentPadding: kSearchFieldContentPadding,
                   prefixIcon: kSearchFieldPrefixIcon,
                   prefixIconConstraints: kSearchFieldIconConstraints,
                   hintText: l10n.searchFieldSearchHint,