fix mock, and refactor per code review suggestion

ubuntu · Dec 28, 2023 · c7688a3 · c7688a3
1 parent 3d8d813
commit c7688a3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/packages/app_center/lib/src/manage/manage_page.dart b/packages/app_center/lib/src/manage/manage_page.dart
@@ -234,6 +234,9 @@ class _ActionButtons extends ConsumerWidget {
       error: (_, __) => ('', const SizedBox.shrink()),
     );
 
+    final updatesInprogress = updatesModel.refreshableSnapNames.isNotEmpty &&
+        !updatesModel.state.isLoading &&
+        updatesModel.activeChangeId != null;
     return Row(
       mainAxisSize: MainAxisSize.min,
       children: [
@@ -306,9 +309,7 @@ class _ActionButtons extends ConsumerWidget {
         ),
         const SizedBox(width: 8),
         PushButton.outlined(
-          onPressed: updatesModel.refreshableSnapNames.isNotEmpty &&
-                  !updatesModel.state.isLoading &&
-                  updatesModel.activeChangeId != null
+          onPressed: updatesInprogress
               ? () => ref
                   .read(updatesModelProvider)
                   .cancelChange(updatesModel.activeChangeId!)

diff --git a/packages/app_center/test/test_utils.mocks.dart b/packages/app_center/test/test_utils.mocks.dart
@@ -1452,6 +1452,16 @@ class MockUpdatesModel extends _i1.Mock implements _i6.UpdatesModel {
         returnValueForMissingStub: _i14.Future<void>.value(),
       ) as _i14.Future<void>);
 
+  @override
+  _i14.Future<void> cancelChange(String? changeId) => (super.noSuchMethod(
+        Invocation.method(
+          #cancelChange,
+          [changeId],
+        ),
+        returnValue: _i14.Future<void>.value(),
+        returnValueForMissingStub: _i14.Future<void>.value(),
+      ) as _i14.Future<void>);
+
   @override
   void addListener(_i15.VoidCallback? listener) => super.noSuchMethod(
         Invocation.method(