Merge pull request #1709 from d-loose/update-lints

refactor: update lints
ubuntu · Jun 24, 2024 · 73b4233 · 73b4233
2 parents 460b236 + 7e337c4
commit 73b4233
Show file tree

Hide file tree

Showing 64 changed files with 1,257 additions and 872 deletions.
diff --git a/melos.yaml b/melos.yaml
@@ -10,7 +10,7 @@ command:
       flutter: '>=3.19.6'
 
     dev_dependencies:
-      ubuntu_lints: ^0.3.1
+      ubuntu_lints: ^0.4.0
 
 scripts:
   # analyze all packages

diff --git a/packages/app_center/integration_test/app_center_test.dart b/packages/app_center/integration_test/app_center_test.dart
@@ -37,7 +37,8 @@ void main() {
     );
     expect(
       find.text(
-          'This is a minimal test package for App Center integration tests.'),
+        'This is a minimal test package for App Center integration tests.',
+      ),
       findsOneWidget,
     );
     expect(

diff --git a/packages/app_center/lib/about/about_providers.dart b/packages/app_center/lib/about/about_providers.dart
@@ -12,18 +12,22 @@ final contributorsProvider = FutureProvider.autoDispose
   final contributors = await getService<GitHub>()
       .repositories
       .listContributors(RepositorySlug.full(repo))
-      .where((c) =>
-          c.type == 'User' &&
-          !designers.contains(c.login) &&
-          !exclude.contains(c.login))
+      .where(
+        (c) =>
+            c.type == 'User' &&
+            !designers.contains(c.login) &&
+            !exclude.contains(c.login),
+      )
       .toList();
   return [
-    ...designers.map((d) => Contributor(
-          login: d,
-          htmlUrl: 'https://github.com/$d',
-          avatarUrl: 'https://avatars.githubusercontent.com/$d',
-        )),
-    ...contributors
+    ...designers.map(
+      (d) => Contributor(
+        login: d,
+        htmlUrl: 'https://github.com/$d',
+        avatarUrl: 'https://avatars.githubusercontent.com/$d',
+      ),
+    ),
+    ...contributors,
   ].sortedBy((c) => c.login?.toLowerCase() ?? '');
 });
 

diff --git a/packages/app_center/lib/appstream/appstream_service.dart b/packages/app_center/lib/appstream/appstream_service.dart
@@ -47,8 +47,17 @@ class _CachedComponent {
         .split(nonWordCharacters)
         .toList();
 
-    return _CachedComponent(component, id, name, keywords, summary, description,
-        origin, package, mediaTypes);
+    return _CachedComponent(
+      component,
+      id,
+      name,
+      keywords,
+      summary,
+      description,
+      origin,
+      package,
+      mediaTypes,
+    );
   }
   final AppstreamComponent component;
   final String id;
@@ -166,7 +175,8 @@ class AppstreamService {
     } else {
       locale = const Locale('en');
       log.info(
-          'Unsupported locale: ${PlatformDispatcher.instance.locale}. Defaulting to "en".');
+        'Unsupported locale: ${PlatformDispatcher.instance.locale}. Defaulting to "en".',
+      );
     }
     return lookupAppLocalizations(locale);
   }

diff --git a/packages/app_center/lib/appstream/appstream_utils.dart b/packages/app_center/lib/appstream/appstream_utils.dart
@@ -104,9 +104,11 @@ extension Metadata on AppstreamComponent {
   }
 
   List<String> get screenshotUrls => screenshots
-      .map((screenshot) => screenshot.images
-          .where((image) => image.type == AppstreamImageType.source)
-          .map((image) => image.url))
+      .map(
+        (screenshot) => screenshot.images
+            .where((image) => image.type == AppstreamImageType.source)
+            .map((image) => image.url),
+      )
       .expand((images) => images)
       .toList();
 }
diff --git a/packages/app_center/lib/deb/deb_page.dart b/packages/app_center/lib/deb/deb_page.dart
@@ -91,13 +91,14 @@ class _DebView extends StatelessWidget {
                     AppstreamUrlType.homepage,
                   ].contains(url.type),
                 )
-                .map((url) => Html(
-                      data:
-                          '<a href="${url.url}">${url.type.localize(l10n)}</a>',
-                      style: {'body': Style(margin: Margins.zero)},
-                      onLinkTap: (url, attributes, element) =>
-                          launchUrlString(url!),
-                    ))
+                .map(
+                  (url) => Html(
+                    data: '<a href="${url.url}">${url.type.localize(l10n)}</a>',
+                    style: {'body': Style(margin: Margins.zero)},
+                    onLinkTap: (url, attributes, element) =>
+                        launchUrlString(url!),
+                  ),
+                )
                 .toList(),
           ),
         ),
@@ -169,7 +170,7 @@ class _DebActionButtons extends ConsumerWidget {
                 builder: (context, ref, child) {
                   final transaction = ref
                       .watch(transactionProvider(debModel.activeTransactionId!))
-                      .whenOrNull(data: (data) => data);
+                      .valueOrNull;
                   return Center(
                     child: SizedBox.square(
                       dimension: kCircularProgressIndicatorHeight,
@@ -198,7 +199,7 @@ class _DebActionButtons extends ConsumerWidget {
           primaryActionButton
         else
           Text(l10n.debPageErrorNoPackageInfo),
-        if (debModel.activeTransactionId != null) cancelButton
+        if (debModel.activeTransactionId != null) cancelButton,
       ].whereNotNull().toList(),
     );
   }
@@ -245,7 +246,8 @@ class _Header extends StatelessWidget {
                 icon: const Icon(YaruIcons.share),
                 onPressed: () {
                   Clipboard.setData(
-                      ClipboardData(text: debModel.component.website!));
+                    ClipboardData(text: debModel.component.website!),
+                  );
                 },
               ),
           ],

diff --git a/packages/app_center/lib/deb/local_deb_model.dart b/packages/app_center/lib/deb/local_deb_model.dart
@@ -40,14 +40,17 @@ class LocalDebModel extends _$LocalDebModel {
     final packageKit = getService<PackageKitService>();
     final activeTransactionId = await packageKit.installLocal(path);
     state = AsyncValue.data(
-        state.value!.copyWith(activeTransactionId: activeTransactionId));
+      state.value!.copyWith(activeTransactionId: activeTransactionId),
+    );
     await packageKit.waitTransaction(activeTransactionId);
     ref.invalidateSelf();
   }
 
   Future<void> cancel() async {
-    assert(state.value?.activeTransactionId != null,
-        'cancel() called without active transaction');
+    assert(
+      state.value?.activeTransactionId != null,
+      'cancel() called without active transaction',
+    );
     final packageKit = getService<PackageKitService>();
     await packageKit.cancelTransaction(state.value!.activeTransactionId!);
     state = AsyncValue.data(state.value!.copyWith(activeTransactionId: null));

diff --git a/packages/app_center/lib/deb/local_deb_page.dart b/packages/app_center/lib/deb/local_deb_page.dart
@@ -133,7 +133,7 @@ class _LocalDebActionButtons extends ConsumerWidget {
                   .textTheme
                   .bodyMedium!
                   .copyWith(fontWeight: FontWeight.bold),
-            )
+            ),
           ],
         ),
       );
@@ -178,7 +178,7 @@ class _LocalDebActionButtons extends ConsumerWidget {
         primaryActionButton,
         if (debData.activeTransactionId != null) ...[
           const SizedBox(width: 8),
-          cancelButton
+          cancelButton,
         ],
       ],
     );

diff --git a/packages/app_center/lib/explore/explore_page.dart b/packages/app_center/lib/explore/explore_page.dart
@@ -23,55 +23,67 @@ class ExplorePage extends ConsumerWidget {
     final l10n = AppLocalizations.of(context);
     return ResponsiveLayoutScrollView(
       slivers: [
-        SliverList.list(children: const [
-          SizedBox(height: kPagePadding),
-          CategoryBanner(category: SnapCategoryEnum.ubuntuDesktop),
-          SizedBox(height: kPagePadding),
-        ]),
+        SliverList.list(
+          children: const [
+            SizedBox(height: kPagePadding),
+            CategoryBanner(category: SnapCategoryEnum.ubuntuDesktop),
+            SizedBox(height: kPagePadding),
+          ],
+        ),
         const CategorySnapList(
           category: SnapCategoryEnum.ubuntuDesktop,
           hideBannerSnaps: true,
         ),
-        SliverList.list(children: const [
-          SizedBox(height: 56),
-          CategoryBanner(category: SnapCategoryEnum.featured),
-          SizedBox(height: kPagePadding),
-        ]),
+        SliverList.list(
+          children: const [
+            SizedBox(height: 56),
+            CategoryBanner(category: SnapCategoryEnum.featured),
+            SizedBox(height: kPagePadding),
+          ],
+        ),
         const CategorySnapList(
           category: SnapCategoryEnum.featured,
           hideBannerSnaps: true,
         ),
-        SliverList.list(children: [
-          const SizedBox(height: 56),
-          _Title(text: SnapCategoryEnum.games.slogan(l10n)),
-          const SizedBox(height: kPagePadding),
-        ]),
+        SliverList.list(
+          children: [
+            const SizedBox(height: 56),
+            _Title(text: SnapCategoryEnum.games.slogan(l10n)),
+            const SizedBox(height: kPagePadding),
+          ],
+        ),
         const CategorySnapList(
           category: SnapCategoryEnum.games,
           numberOfSnaps: 4,
           showScreenshots: true,
           onlyFeatured: true,
         ),
-        SliverList.list(children: [
-          const SizedBox(height: 56),
-          _Title(text: l10n.explorePageCategoriesLabel),
-          const SizedBox(height: kPagePadding),
-        ]),
+        SliverList.list(
+          children: [
+            const SizedBox(height: 56),
+            _Title(text: l10n.explorePageCategoriesLabel),
+            const SizedBox(height: kPagePadding),
+          ],
+        ),
         const _CategoryList(),
-        SliverList.list(children: const [
-          SizedBox(height: 56),
-          CategoryBanner(category: SnapCategoryEnum.development),
-          SizedBox(height: kPagePadding),
-        ]),
+        SliverList.list(
+          children: const [
+            SizedBox(height: 56),
+            CategoryBanner(category: SnapCategoryEnum.development),
+            SizedBox(height: kPagePadding),
+          ],
+        ),
         const CategorySnapList(
           category: SnapCategoryEnum.development,
           hideBannerSnaps: true,
         ),
-        SliverList.list(children: const [
-          SizedBox(height: 56),
-          CategoryBanner(category: SnapCategoryEnum.productivity),
-          SizedBox(height: kPagePadding),
-        ]),
+        SliverList.list(
+          children: const [
+            SizedBox(height: 56),
+            CategoryBanner(category: SnapCategoryEnum.productivity),
+            SizedBox(height: kPagePadding),
+          ],
+        ),
         const CategorySnapList(
           category: SnapCategoryEnum.productivity,
           hideBannerSnaps: true,
@@ -109,18 +121,22 @@ class _CategoryList extends StatelessWidget {
       crossAxisCount: ResponsiveLayout.of(context).snapInfoColumnCount,
       children: SnapCategoryEnum.values
           .whereNot((category) => category.hidden)
-          .map((category) => InkWell(
-                onTap: () => StoreNavigator.pushSearch(context,
-                    category: category.categoryName),
-                child: Row(
-                  mainAxisSize: MainAxisSize.min,
-                  children: [
-                    Icon(category.icon(true)),
-                    const SizedBox(width: 8),
-                    Text(category.localize(AppLocalizations.of(context)))
-                  ],
-                ),
-              ))
+          .map(
+            (category) => InkWell(
+              onTap: () => StoreNavigator.pushSearch(
+                context,
+                category: category.categoryName,
+              ),
+              child: Row(
+                mainAxisSize: MainAxisSize.min,
+                children: [
+                  Icon(category.icon(true)),
+                  const SizedBox(width: 8),
+                  Text(category.localize(AppLocalizations.of(context))),
+                ],
+              ),
+            ),
+          )
           .toList(),
     );
   }