fix: GitHub Action to scan correct folders for typos #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QQ: Should I also be creating issues for this type of thing before submitting the PR? |
If you identify something that only I can fix or similar then yeah create an issue, otherwise not really needed ^^ |
|
Also thank you for your PRs ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in #33 that the
check-spellingaction was failing due to attempting to scan a folder that doesn't exist.The pages folder doesn't exist and causes the
typoscommand to fail, so I just removed it.I validated locally, but saw a slightly different error message. It's possible there is another issue as well, but this should at least fix something.
