Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reviewed python basics #7

Merged
merged 7 commits into from
Jan 19, 2023
Merged

reviewed python basics #7

merged 7 commits into from
Jan 19, 2023

Conversation

fangohr
Copy link
Member

@fangohr fangohr commented Dec 15, 2022 •
edited
Loading 

    - [X] add numpy section 
    - [X] add link to Python book
    - [X] change docstring example from np.mean to something simple (sqrt / abs)
    - [X] remove `!` after print is not return

Also improved some inaccuracies.

@fangohr fangohr requested review from lang-m and samjrholt December 15, 2022 16:53
lang-m
lang-m reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@lang-m lang-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few minor suggestions.

fangohr and others added 4 commits December 15, 2022 20:15
@lang-m lang-m merged commit c439148 into master Jan 19, 2023
@lang-m lang-m deleted the review-python-basics branch January 19, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lang-m lang-m lang-m approved these changes

@samjrholt samjrholt Awaiting requested review from samjrholt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fangohr @lang-m