Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for subsequent author substitution #228

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add support for subsequent author substitution #228

wants to merge 18 commits into from

Conversation

Drodt
Copy link
Contributor

@Drodt Drodt commented Oct 8, 2024 •
edited
Loading

Fixes #219. Fixes #229 (as a first approximation)

Also fixes the error that affixes for bibliography layout were ignored. And updates archives.

Adds 96 tests to citeproc-pass.txt.

Still a draft until:

  • Code is reworked to be a bit nicer
  • Tests for bibliography are supported (See Support for Citeproc bibliography tests #229).
  • All relevant tests pass:
    • name_SubsequentAuthorSubstituteSingleField
    • name_SubstitutePartialEach
    • name_SubsequentAuthorSubstituteMultipleNames

@Drodt Drodt marked this pull request as ready for review October 17, 2024 07:20
@Drodt
Copy link
Contributor Author

Drodt commented Nov 25, 2024

This is ready to merge.

PgBiel
PgBiel reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@PgBiel PgBiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, here are some initial thoughts.

archive/locales/de-AT.cbor Outdated Show resolved Hide resolved
tests/citeproc.rs Outdated Show resolved Hide resolved
tests/f219.rs Outdated Show resolved Hide resolved
tests/f219.rs Outdated Show resolved Hide resolved
@PgBiel PgBiel mentioned this pull request Feb 3, 2025
Merged
2 tasks
@reknih
Copy link
Member

reknih commented Feb 5, 2025

I have merged main in here, removed the HTML testing in favor of #273, and got rid of the archive updates.

Two tests are failing now:

  • bugreports_parenthesis, first passed in your PR before my merge
  • substitute_SuppressOrdinaryVariable, first passed in 1058be7 on main

@reknih
Copy link
Member

reknih commented Feb 5, 2025

Also moved f219.rs to a local test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PgBiel PgBiel PgBiel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

subsequent-author-substitute is not respected Support for Citeproc bibliography tests
4 participants
@Drodt @reknih @PgBiel @DerDrodt