Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass IsBase64 options correctly #2549

Merged
merged 4 commits into from
Jan 17, 2025
Merged

fix: pass IsBase64 options correctly #2549

merged 4 commits into from
Jan 17, 2025
+15 −5

Conversation

aseyfpour
Copy link
Contributor

@aseyfpour aseyfpour commented Nov 1, 2024 •
edited by braaar
Loading

Description

In the IsBase64 decorator, constraints weren’t passed to isBase64. This issue has been fixed in this PR.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #2548
closes #2383

aseyfpour and others added 3 commits November 1, 2024 15:26
@aseyfpour
Copy link
Contributor Author

It’s been a month since the last changes. I’d appreciate it if anyone could involve a reviewer for this PR.

braaar
braaar approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@braaar braaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to a cleaner test implementation than #2383, I would like to merge this.

Thank you, and sorry for the wait

@braaar braaar changed the title fix: fill base64 options correctly fix: fill IsBase64 options correctly Jan 17, 2025
@braaar braaar changed the title fix: fill IsBase64 options correctly fix: pass IsBase64 options correctly Jan 17, 2025
@braaar braaar merged commit 0c87beb into typestack:develop Jan 17, 2025
5 checks passed
@braaar braaar mentioned this pull request Jan 17, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braaar braaar braaar approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: base64 options doesn't apply
2 participants
@aseyfpour @braaar