Add @threadUnsafe3
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satorg
reviewed
Nov 13, 2023
Comment on lines
+36
to
+37
| test("threadUnsafe3 respected on Scala 3 only") { | ||
| Future.sequence(List(Future(foo), Future(foo))).map { _ => |
|
Thanks for the review 🙂 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This annotation is a nice optimization for the common case where a
lazy valinitializes a pure value and does not need to be synchronized.Code that is performance sensitive on Scala 2 will still need to avoid
lazy val, but for casual code that is already using it at least we can squeeze out some extra performance on Scala 3.