Widen peerDependencies to allow @glimmer/component v2 #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given the #777 was OK, is this able to be merged? |
|
this may need a rebase |
|
can we get a release with this changes? |
|
Yes, but this pr has a conflict |
SergeAstapov
force-pushed
the
glimmer-component-v2
branch
from
c3781b3 to
bb22bd0
Compare
|
@SergeAstapov can you rebase the PR? thanks |
|
@mkszepp @NullVoxPopuli sorry for delay, rebased branch |
NullVoxPopuli
approved these changes
Jan 15, 2025
|
Can you also pr to the main branch? Thanks! |
@NullVoxPopuli this already was done in #777 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, @glimmer/component v2 is not allowed by current peerDependencies
Same as #777, but targets
v1.xbranch