fix: Optimize CI fails sporadically.

Signed-off-by: tao.yang <[email protected]>

.github/workflows/lint-golang.yaml

@@ -29,8 +29,8 @@ jobs:
     name: Deduce required tests from code changes
     runs-on: ubuntu-latest
     outputs:
-      check: ${{ steps.result.outputs.check }}
-      ref: ${{ steps.result.outputs.ref }}
+      check: ${{ env.check }}
+      ref: ${{ env.ref }}
     steps:
       - name: Check Go Code Changes
         uses: dorny/[email protected]
@@ -53,22 +53,22 @@ jobs:
         run: |
           if ${{ github.event_name == 'push' }} ; then
               echo "trigger by push"
-              echo "::set-output name=check::true"
-              echo "::set-output name=ref::${{ github.sha }}"
+              echo "check=true" >> $GITHUB_ENV
+              echo "ref=${{ github.sha }}" >> $GITHUB_ENV
           elif ${{ github.event_name == 'pull_request' }} ; then
               echo "trigger by pull_request"
               flag=${{ steps.filter_pr.outputs.src }}
-              echo "::set-output name=check::${flag}"
+              echo "check=${flag}" >> $GITHUB_ENV
               ref=${{ github.event.pull_request.head.sha }}
-              echo "::set-output name=ref::${ref}"
+              echo "ref=${ref}" >> $GITHUB_ENV
           elif ${{ inputs.ref != '' }} ; then
               echo "trigger by workflow_call"
-              echo "::set-output name=check::true"
-              echo "::set-output name=ref::${{ inputs.ref }}"
+              echo "check=true" >> $GITHUB_ENV
+              echo "ref=${{ inputs.ref }}" >> $GITHUB_ENV
           elif ${{ github.event_name == 'workflow_dispatch' }} ; then
               echo "trigger by workflow_dispatch"
-              echo "::set-output name=check::true"
-              echo "::set-output name=ref::${{ github.event.inputs.ref }}"
+              echo "check=true" >> $GITHUB_ENV
+              echo "ref=${{ github.event.inputs.ref }}" >> $GITHUB_ENV
           else
               echo "error, unexpected event "
               exit 1
@@ -80,9 +80,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: 1.21.4
+          go-version: 1.23.2
 
       - name: Checkout code
         uses: actions/checkout@v4
@@ -103,7 +103,7 @@ jobs:
       - name: Run golangci-lint
         id: golangci_lint
         continue-on-error: true
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v6
         with:
           version: latest
 
@@ -136,9 +136,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: 1.21.4
+          go-version: 1.23.2
 
       - name: Checkout code
         uses: actions/checkout@v4
@@ -190,9 +190,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: 1.21.4
+          go-version: 1.23.2
 
       - name: Checkout code
         uses: actions/checkout@v4

go.mod

@@ -75,6 +75,7 @@ require github.com/google/go-cmp v0.6.0 // indirect
 require k8s.io/component-base v0.29.4 // indirect
 
 require (
+	github.com/hashicorp/go-multierror v1.1.1
 	go.uber.org/automaxprocs v1.5.3
 	k8s.io/kubectl v0.26.3
 )
@@ -113,6 +114,7 @@ require (
 	github.com/google/uuid v1.3.0 // indirect
 	github.com/gorilla/handlers v1.5.1 // indirect
 	github.com/grafana/pyroscope-go/godeltaprof v0.1.3 // indirect
+	github.com/hashicorp/errwrap v1.1.0 // indirect
 	github.com/hashicorp/hcl v1.0.0 // indirect
 	github.com/huandu/xstrings v1.3.3 // indirect
 	github.com/imdario/mergo v0.3.13 // indirect

go.sum

@@ -341,6 +341,11 @@ github.com/grafana/pyroscope-go v1.0.2/go.mod h1:bShDKsVZdzxq+Ol6no0JKigU9y5FTWU
 github.com/grafana/pyroscope-go/godeltaprof v0.1.3 h1:eunWpv1B3Z7ZK9o4499EmQGlY+CsDmSZ4FbxjRx37uk=
 github.com/grafana/pyroscope-go/godeltaprof v0.1.3/go.mod h1:1HSPtjU8vLG0jE9JrTdzjgFqdJ/VgN7fvxBNq3luJko=
 github.com/gregjones/httpcache v0.0.0-20180305231024-9cad4c3443a7/go.mod h1:FecbI9+v66THATjSRHfNgh1IVFe/9kFxbXtjV0ctIMA=
+github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
+github.com/hashicorp/errwrap v1.1.0 h1:OxrOeh75EUXMY8TBjag2fzXGZ40LB6IKw45YeGUDY2I=
+github.com/hashicorp/errwrap v1.1.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
+github.com/hashicorp/go-multierror v1.1.1 h1:H5DkEtf6CXdFp0N0Em5UCwQpXMWke8IA0+lD48awMYo=
+github.com/hashicorp/go-multierror v1.1.1/go.mod h1:iw975J/qwKPdAO1clOe2L8331t/9/fmwbPZ6JB6eMoM=
 github.com/hashicorp/golang-lru v0.5.0/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8=
 github.com/hashicorp/golang-lru v0.5.1/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8=
 github.com/hashicorp/hcl v1.0.0 h1:0Anlzjpi4vEasTeNFn2mLJgTSwt0+6sfsiTG8qcWGx4=

test/e2e/common/constant.go

@@ -32,6 +32,8 @@ const (
 	BatchCreateTimeout         = time.Minute * 5
 	KdoctorCheckTime           = time.Minute * 10
 	SpiderSyncMultusTime       = time.Minute * 2
+	InformerSyncStatusTime     = time.Second * 30
+	KDoctorRunTimeout          = time.Minute * 10
 )
 
 var ForcedWaitingTime = time.Second

test/e2e/common/node.go

@@ -8,6 +8,7 @@ import (
 	"fmt"
 	"os/exec"
 
+	"github.com/hashicorp/go-multierror"
 	. "github.com/onsi/ginkgo/v2"
 	e2e "github.com/spidernet-io/e2eframework/framework"
 	corev1 "k8s.io/api/core/v1"
@@ -55,3 +56,36 @@ func RestartNodeUntilClusterReady(ctx context.Context, frame *e2e.Framework, nod
 	GinkgoWriter.Println("Check that the status of all Pods in the cluster is running")
 	return nil
 }
+
+func GetNodeNetworkInfo(ctx context.Context, frame *e2e.Framework, nodeList []string) error {
+	var jobResult *multierror.Error
+	for _, node := range nodeList {
+		GinkgoWriter.Printf("=============== Check the network information of the node %v ============== \n", node)
+		commands := []string{
+			"ip a",
+			"ip link show",
+			"ip n",
+			"ip -6 n",
+			"ip rule",
+			"ip -6 rule",
+			"ip route",
+			"ip route show table 100",
+			"ip route show table 101",
+			"ip route show table 500",
+			"ip -6 route",
+			"ip -6 route show table 100",
+			"ip -6 route show table 101",
+			"ip -6 route show table 500",
+		}
+
+		for _, command := range commands {
+			GinkgoWriter.Printf("--------------- execute %v in node: %v ------------ \n", command, node)
+			out, err := frame.DockerExecCommand(ctx, node, command)
+			if err != nil {
+				jobResult = multierror.Append(jobResult, fmt.Errorf("node %v: command '%v' failed with error: %w, output: %s", node, command, err, out))
+			}
+		}
+	}
+
+	return jobResult.ErrorOrNil()
+}

test/e2e/common/pod.go

@@ -9,7 +9,9 @@ import (
 	"time"
 
 	"github.com/spidernet-io/spiderpool/pkg/constant"
+	"github.com/spidernet-io/spiderpool/pkg/utils/retry"
 
+	"github.com/hashicorp/go-multierror"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 	e2e "github.com/spidernet-io/e2eframework/framework"
@@ -48,7 +50,14 @@ func GenerateExamplePodYaml(podName, namespace string) *corev1.Pod {
 func CreatePodUntilReady(frame *e2e.Framework, podYaml *corev1.Pod, podName, namespace string, waitPodStartTimeout time.Duration) (pod *corev1.Pod, podIPv4, podIPv6 string) {
 	// create pod
 	GinkgoWriter.Printf("create pod %v/%v \n", namespace, podName)
-	err := frame.CreatePod(podYaml)
+	err := retry.RetryOnConflictWithContext(context.Background(), retry.DefaultBackoff, func(ctx context.Context) error {
+		err := frame.CreatePod(podYaml)
+		if err != nil {
+			GinkgoLogr.Error(fmt.Errorf("failed to create pod %v/%v, error: %v", namespace, podName, err), "Failed")
+			return err
+		}
+		return nil
+	})
 	Expect(err).NotTo(HaveOccurred(), "failed to create pod")
 
 	// wait for pod ip
@@ -138,3 +147,34 @@ func ValidatePodIPConflict(podList *corev1.PodList) error {
 	}
 	return nil
 }
+
+func GetPodNetworkInfo(ctx context.Context, frame *e2e.Framework, podList *corev1.PodList) error {
+	var jobResult *multierror.Error
+	for _, pod := range podList.Items {
+		GinkgoWriter.Printf("=============== Check the network information of the pod %v/%v ============== \n", pod.Namespace, pod.Name)
+		commands := []string{
+			"ip a",
+			"ip link show",
+			"ip n",
+			"ip -6 n",
+			"ip rule",
+			"ip -6 rule",
+			"ip route",
+			"ip route show table 100",
+			"ip route show table 101",
+			"ip -6 route",
+			"ip -6 route show table 100",
+			"ip -6 route show table 101",
+		}
+
+		for _, command := range commands {
+			GinkgoWriter.Printf("--------------- execute %v in pod: %v/%v on node: %v ------------ \n", command, pod.Namespace, pod.Name, pod.Spec.NodeName)
+			out, err := frame.ExecCommandInPod(pod.Name, pod.Namespace, command, ctx)
+			if err != nil {
+				jobResult = multierror.Append(jobResult, fmt.Errorf("pod %v/%v: command '%v' failed with error: %w, output: %s", pod.Namespace, pod.Name, command, err, out))
+			}
+		}
+	}
+
+	return jobResult.ErrorOrNil()
+}

test/e2e/common/spiderpool.go

@@ -470,7 +470,7 @@ func DeleteIPPoolUntilFinish(f *frame.Framework, poolName string, ctx context.Co
 		default:
 			_, err := GetIppoolByName(f, poolName)
 			if err != nil {
-				GinkgoWriter.Printf("IPPool '%s' has been removed，error: %v", poolName, err)
+				GinkgoWriter.Printf("IPPool '%s' has been removed, error: %v", poolName, err)
 				return nil
 			}
 			time.Sleep(ForcedWaitingTime)
@@ -562,7 +562,7 @@ func WaitWorkloadDeleteUntilFinish(ctx context.Context, f *frame.Framework, name
 			_, err := GetWorkloadByName(f, namespace, name)
 			if err != nil {
 				if api_errors.IsNotFound(err) {
-					GinkgoWriter.Printf("workload '%s/%s' has been removed，error: %v", namespace, name, err)
+					GinkgoWriter.Printf("workload '%s/%s' has been removed, error: %v", namespace, name, err)
 					return nil
 				}
 				return err
@@ -877,14 +877,15 @@ func CheckIppoolSanity(f *frame.Framework, poolName string) error {
 		podYaml, err := f.GetPod(podName, podNS)
 		if err != nil {
 			if api_errors.IsNotFound(err) {
-				GinkgoLogr.Error(fmt.Errorf("pod %s/%s does not exist", podNS, podName), "Failed")
+				GinkgoLogr.Error(fmt.Errorf("the pod %s/%s in ippool %s, but pod does not exist in kubernetes", podNS, podName, poolName), "Failed")
+				isSanity = false
+				continue
 			} else {
 				return fmt.Errorf("failed to get pod %s/%s, error: %v", podNS, podName, err)
 			}
 		}
-
 		podNetworkIPs, err := ParsePodNetworkAnnotation(f, podYaml)
-		if nil != err {
+		if err != nil {
 			return fmt.Errorf("failed to parse pod %s/%s network annotation \n pod yaml %v, \n error: %v ", podNS, podName, podYaml, err)
 		}
 
@@ -917,9 +918,11 @@ func CheckIppoolSanity(f *frame.Framework, poolName string) error {
 		wep, err := GetWorkloadByName(f, podYaml.Namespace, podYaml.Name)
 		if err != nil {
 			if api_errors.IsNotFound(err) {
-				GinkgoLogr.Error(fmt.Errorf("endpoint %s/%s dose not exist", podYaml.Namespace, podYaml.Name), "Failed")
+				GinkgoLogr.Error(fmt.Errorf("pod %s/%s exists in ippool %s, but endpoint does not exist", podYaml.Namespace, podYaml.Name, poolName), "Failed")
+				isSanity = false
+				continue
 			}
-			return fmt.Errorf("failed to get endpoint %s/%s, error %v", podYaml.Namespace, podYaml.Name, err)
+			return fmt.Errorf("pod %s/%s exists in ippool %s, but failed to get endpoint, error %v", podYaml.Namespace, podYaml.Name, poolName, err)
 		}
 
 		podUsedIPs := convert.GroupIPAllocationDetails(wep.Status.Current.UID, wep.Status.Current.IPs)
@@ -941,24 +944,50 @@ func CheckIppoolSanity(f *frame.Framework, poolName string) error {
 		}
 	}
 
-	if *ippool.Status.AllocatedIPCount > *ippool.Status.TotalIPCount {
-		GinkgoWriter.Printf(
-			"allocated IP count (%v) exceeds total IP count (%v) \n",
-			*ippool.Status.AllocatedIPCount, *ippool.Status.TotalIPCount,
-		)
-		isSanity = false
-	}
+	// The status of IPPool is automatically synchronized by the IPPool informer based on the events it receives.
+	// In the CI environment, the creation of IPPools happens very quickly, and their health checks are performed promptly.
+	// When checking the TotalIPCount status, if the spiderpool-controller undergoes a leader election or the informer has not yet completed synchronization,
+	// the IPPool status TotalIPCount may be nil. This can lead to a panic.
+	// In such cases, try waiting for the informer to complete status synchronization before checking the robustness of the IPPool.
+	ctx, cancel := context.WithTimeout(context.Background(), InformerSyncStatusTime)
+	defer cancel()
+	for {
+		select {
+		case <-ctx.Done():
+			return fmt.Errorf("waiting for informer to synchronize IPPool %s status timed out", poolName)
+		default:
+			if ippool.Status.AllocatedIPCount == nil || ippool.Status.TotalIPCount == nil {
+				GinkgoLogr.Error(fmt.Errorf("IPPool %s has nil status fields, retrying", poolName), "Failed")
+				ippool, err = GetIppoolByName(f, poolName)
+				if err != nil {
+					if api_errors.IsNotFound(err) {
+						return fmt.Errorf("ippool %s does not exist", poolName)
+					}
+					return fmt.Errorf("failed to get ippool %s, error %v", poolName, err)
+				}
+				time.Sleep(ForcedWaitingTime)
+				continue
+			}
 
-	// Ensure that the IP pool's reported usage matches the actual usage
-	if actualIPUsageCount != int(*ippool.Status.AllocatedIPCount) {
-		GinkgoWriter.Printf("IPPool %s usage count mismatch: expected %d, got %d \n", poolName, actualIPUsageCount, *ippool.Status.AllocatedIPCount)
-		isSanity = false
-	}
+			if *ippool.Status.AllocatedIPCount > *ippool.Status.TotalIPCount {
+				GinkgoWriter.Printf(
+					"allocated IP count (%v) exceeds total IP count (%v) \n",
+					*ippool.Status.AllocatedIPCount, *ippool.Status.TotalIPCount,
+				)
+				isSanity = false
+			}
+			// Ensure that the IP pool's reported usage matches the actual usage
+			if actualIPUsageCount != int(*ippool.Status.AllocatedIPCount) {
+				GinkgoWriter.Printf("IPPool %s usage count mismatch: expected %d, got %d \n", poolName, actualIPUsageCount, *ippool.Status.AllocatedIPCount)
+				isSanity = false
+			}
 
-	if !isSanity {
-		return fmt.Errorf("IPPool %s sanity check failed", poolName)
-	}
+			if !isSanity {
+				return fmt.Errorf("IPPool %s sanity check failed", poolName)
+			}
 
-	GinkgoWriter.Printf("Successfully checked IPPool %s sanity, IPPool record information is correct \n", poolName)
-	return nil
+			GinkgoWriter.Printf("Successfully checked IPPool %s sanity, IPPool record information is correct \n", poolName)
+			return nil
+		}
+	}
 }

test/e2e/coordinator/macvlan-underlay-one/macvlan_underlay_one_suite_test.go

@@ -33,7 +33,6 @@ var (
 	request     *kdoctorV1beta1.NetHttpRequest
 	condition   *kdoctorV1beta1.NetSuccessCondition
 	schedule    *kdoctorV1beta1.SchedulePlan
-	run         = true
 )
 
 var _ = BeforeSuite(func() {