This repository has been archived by the owner on Sep 18, 2021. It is now read-only.
Solution for #94: username link drops capitalisation #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `name` and `chunk` can be references to the same object, the destructive `name.downcase!` also affects `chunk`. This patch ensures that the two are never the same object, and avoids the unintended side-effect.
|
The travis build failed because of #104, which is unrelated. |
|
Thank you very much. I'll fix travis shortly too. |
jakl
added a commit
that referenced
this pull request
Dec 20, 2013
…talisation Solution for #94: username link drops capitalisation
|
Since you also accepted twitter/twitter-text-compliance#64, 6760598 is a duplicate and can safely be reverted. |
|
Oh thanks - I should look for other duplicates as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
nameandchunkcan be references to the same object,the destructive
name.downcase!also affectschunk. This patchensures that the two are never the same object, and avoids the
unintended side-effect.