feat(side-panel): add useSidePanelState hook, animation zhoosh #4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 861c23f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:XL
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Type: Documentation
|
View your CI Pipeline Execution ↗ for commit 861c23f.
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit b4ba31b.
☁️ Nx Cloud last updated this comment at |
|
Size Change: +487 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
side-panel/zhoosh
|
| Run status |
|
| Run duration | 02m 01s |
| Commit |
|
| Committer | “nora |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 861c23f:
|
PixeledCode
reviewed
Feb 5, 2025
krisantrobus
reviewed
Feb 5, 2025
krisantrobus
reviewed
Feb 5, 2025
krisantrobus
reviewed
Feb 5, 2025
krisantrobus
reviewed
Feb 5, 2025
krisantrobus
reviewed
Feb 7, 2025
| @@ -83,7 +89,7 @@ const SidePanelContents = React.forwardRef<HTMLDivElement, SidePanelContentsProp | |||
| {...safelySpreadBoxProps(props)} | |||
| position="absolute" | |||
| role="dialog" | |||
| as={ModalDialogPrimitiveContent as any} | |||
| as={getAs(isMobile)} | |||
There was a problem hiding this comment.
nit: i feel like this would just be a ternary and save some lines
There was a problem hiding this comment.
good catch, just pushed this
krisantrobus
previously approved these changes
Feb 7, 2025
PixeledCode
approved these changes
Feb 11, 2025
|
🚀 |
serifluous
approved these changes
Feb 11, 2025
nkrantz
added
the
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
side-panel/zhoosh
|
| Run status |
|
| Run duration | 06m 03s |
| Commit |
|
| Committer | Nora Krantz |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
krisantrobus
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heightprop to LivePreview