Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http, gateway, model, validate): Add support for premium apps #2282

Merged
merged 25 commits into from
May 31, 2024
Merged

feat(http, gateway, model, validate): Add support for premium apps #2282

merged 25 commits into from
May 31, 2024

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Sep 28, 2023 •
edited
Loading

  • Adds the new Entitlement and SKU entities.
  • Implements the EntitlementCreate, EntitlementUpdate and EntitlementDelete gateway events.
  • Adds a new field to interactions entitlements
  • Adds new http methods get_entitlements(), create_test_entitlement(), delete_test_entitlement() and get_skus.
  • Supports new PremiumSubscription interaction response type.

Refs:

@suneettipirneni suneettipirneni requested a review from a team September 28, 2023 03:38
@suneettipirneni suneettipirneni self-assigned this Sep 28, 2023
@github-actions github-actions bot added c-cache Affects the cache crate c-gateway Affects the gateway crate c-http Affects the http crate c-http-ratelimiting Affects the http ratelimiting crate c-model Affects the model crate c-validate Affects the validate crate t-feature Addition of a new feature labels Sep 28, 2023
@suneettipirneni suneettipirneni changed the title feat(http, gateway, model): Add support for premium apps feat(http, gateway, model, validate): Add support for premium apps Sep 28, 2023
@github-actions github-actions bot added the c-standby Affects the standby crate label Sep 28, 2023
@suneettipirneni suneettipirneni requested a review from a team October 21, 2023 17:54
@suneettipirneni suneettipirneni enabled auto-merge (squash) October 21, 2023 17:54
laralove143
laralove143 requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@laralove143 laralove143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding this

twilight-http/src/client/mod.rs Show resolved Hide resolved
twilight-http/src/request/application/monetization/get_entitlements.rs Show resolved Hide resolved
twilight-model/src/application/interaction/mod.rs Outdated Show resolved Hide resolved
twilight-model/src/application/monetization/sku.rs Outdated Show resolved Hide resolved
twilight-model/src/application/monetization/sku_type.rs Outdated Show resolved Hide resolved
ImDarkDiamond
ImDarkDiamond suggested changes Oct 25, 2023
View reviewed changes
twilight-model/src/application/monetization/sku.rs Outdated Show resolved Hide resolved
twilight-model/src/application/monetization/sku_flags.rs Outdated Show resolved Hide resolved
twilight-model/src/application/monetization/sku_type.rs Outdated Show resolved Hide resolved
twilight-model/src/id/marker.rs Outdated Show resolved Hide resolved
@Gelbpunkt
Copy link
Member

Are you still interested in continuing this? I'd love to get this in for the next release and thought I'd ask so we can get this moving forward again.

@suneettipirneni
Copy link
Member Author

Are you still interested in continuing this? I'd love to get this in for the next release and thought I'd ask so we can get this moving forward again.

I’d be happy to hand this over to anyone who has access to premium apps. For me it’s difficult to iterate on this without any means to test it.

HTGAzureX1212
HTGAzureX1212 reviewed Dec 30, 2023
View reviewed changes
Copy link
Contributor

@HTGAzureX1212 HTGAzureX1212 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will approve once ImDarkDiamond's changes suggested have been implemented.

laralove143
laralove143 approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@laralove143 laralove143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you for this

HTGAzureX1212
HTGAzureX1212 approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@HTGAzureX1212 HTGAzureX1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@suneettipirneni suneettipirneni merged commit 23414dc into twilight-rs:main May 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erk- Erk- Erk- left review comments

@laralove143 laralove143 laralove143 approved these changes

@HTGAzureX1212 HTGAzureX1212 HTGAzureX1212 approved these changes

@ImDarkDiamond ImDarkDiamond Awaiting requested review from ImDarkDiamond

Assignees

@suneettipirneni suneettipirneni

Labels
c-cache Affects the cache crate c-gateway Affects the gateway crate c-http Affects the http crate c-http-ratelimiting Affects the http ratelimiting crate c-model Affects the model crate c-standby Affects the standby crate c-validate Affects the validate crate t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@suneettipirneni @Gelbpunkt @Erk- @HTGAzureX1212 @ImDarkDiamond @laralove143