refactor(auth): update SSO provider selection logic #9975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refined the logic to check for SSO providers before setting the sign-in step. Consolidated conditions to ensure clarity and avoid redundant checks.
guillim
approved these changes
Feb 3, 2025
FelixMalfait
approved these changes
Feb 3, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the SSO provider selection logic in the authentication flow, improving the handling of multiple SSO providers and authentication methods.
- Modified
SignInUpWorkspaceScopeFormEffect.tsxto check for SSO-only authentication before evaluating provider count, preventing unnecessary SSO selection steps - Added explicit condition
hasOnlySSOProvidersEnabledto ensure SSO selection only appears when it's the sole authentication method - Improved auto-redirect logic when single SSO provider is available and no other auth methods exist
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
50
to
53
| const hasOnlySSOProvidersEnabled = | ||
| !workspaceAuthProviders.google && | ||
| !workspaceAuthProviders.microsoft && | ||
| !workspaceAuthProviders.password; |
There was a problem hiding this comment.
style: consider extracting hasOnlySSOProvidersEnabled into a reusable function since it's a core auth flow check
|
Thanks @AMoreaux for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refined the logic to check for SSO providers before setting the sign-in step. Consolidated conditions to ensure clarity and avoid redundant checks.