-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions to upgrade to 0.41 in docs #9964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds upgrade documentation for version 0.41.0 and modifies the workflow view seeding command, with potential data source management issues.
- Potential bug in
packages/twenty-server/src/database/commands/upgrade-version/0-41/0-41-seed-workflow-views.command.ts
: Data source is destroyed before seeding workspace favorites, which could cause runtime errors - Missing cleanup in
seedWorkflowViews
method when connecting to new data source inpackages/twenty-server/src/database/commands/upgrade-version/0-41/0-41-seed-workflow-views.command.ts
- Added documentation for v0.41.0 upgrade in
packages/twenty-website/src/content/developers/self-hosting/upgrade-guide.mdx
with removal ofAUTH_MICROSOFT_TENANT_ID
environment variable
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
@@ -77,6 +77,8 @@ export class SeedWorkflowViewsCommand extends ActiveWorkspacesCommandRunner { | |||
workflowObjectMetadata.id, | |||
dryRun, | |||
); | |||
|
|||
this.twentyORMGlobalManager.destroyDataSourceForWorkspace(workspaceId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: destroying the data source here will cause errors in seedWorkspaceFavorite() which still needs to access repositories
this.twentyORMGlobalManager.destroyDataSourceForWorkspace(workspaceId); | |
// Destroy data source after all operations are complete | |
this.twentyORMGlobalManager.destroyDataSourceForWorkspace(workspaceId); |
Log
|
As per title
Also: