Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to upgrade to 0.41 in docs #9964

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Add instructions to upgrade to 0.41 in docs #9964

merged 2 commits into from
Feb 1, 2025

Conversation

guillim
Copy link
Contributor

@guillim guillim commented Jan 31, 2025

As per title

Also:

  • making sure to destroy datasource in upgrade commands to lower memory usage

@guillim guillim self-assigned this Jan 31, 2025
@guillim guillim requested a review from charlesBochet January 31, 2025 18:26
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds upgrade documentation for version 0.41.0 and modifies the workflow view seeding command, with potential data source management issues.

  • Potential bug in packages/twenty-server/src/database/commands/upgrade-version/0-41/0-41-seed-workflow-views.command.ts: Data source is destroyed before seeding workspace favorites, which could cause runtime errors
  • Missing cleanup in seedWorkflowViews method when connecting to new data source in packages/twenty-server/src/database/commands/upgrade-version/0-41/0-41-seed-workflow-views.command.ts
  • Added documentation for v0.41.0 upgrade in packages/twenty-website/src/content/developers/self-hosting/upgrade-guide.mdx with removal of AUTH_MICROSOFT_TENANT_ID environment variable

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -77,6 +77,8 @@ export class SeedWorkflowViewsCommand extends ActiveWorkspacesCommandRunner {
workflowObjectMetadata.id,
dryRun,
);

this.twentyORMGlobalManager.destroyDataSourceForWorkspace(workspaceId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: destroying the data source here will cause errors in seedWorkspaceFavorite() which still needs to access repositories

Suggested change
this.twentyORMGlobalManager.destroyDataSourceForWorkspace(workspaceId);
// Destroy data source after all operations are complete
this.twentyORMGlobalManager.destroyDataSourceForWorkspace(workspaceId);

@charlesBochet charlesBochet changed the title litte adjustment adfter 041 Add instructions to upgrade to 0.41 in docs Feb 1, 2025
@charlesBochet charlesBochet merged commit c9ca87f into main Feb 1, 2025
32 checks passed
@charlesBochet charlesBochet deleted the little-041 branch February 1, 2025 11:11
Copy link

github-actions bot commented Feb 1, 2025

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected token C in JSON at position 0
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5591:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5562:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5571:7)�[39m
danger-results://tmp/danger-results-186accfe.json

Generated by 🚫 dangerJS against c7172b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants