Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add createMany fields to fieldMetadataService to batch field creation #9957

Merged
merged 4 commits into from
Feb 4, 2025
+297 −200
Merged

add createMany fields to fieldMetadataService to batch field creation #9957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22fec0e
add createmany fields
Weiko Jan 31, 2025
377be71
Merge branch 'main' into c--add-create-many-field-metadata-method-to-…
Weiko Feb 3, 2025
bc22483
refactor a bit
Weiko Feb 3, 2025
1f2576e
more refactoring
Weiko Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions packages/twenty-server/src/database/commands/data-seed-dev-workspace.command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,13 +265,12 @@ export class DataSeedWorkspaceCommand extends CommandRunner {
workspaceId,
);

for (const customField of DEV_SEED_COMPANY_CUSTOM_FIELDS) {
// TODO: Use createMany once implemented for better performances
await this.fieldMetadataService.createOne({
await this.fieldMetadataService.createMany(
DEV_SEED_COMPANY_CUSTOM_FIELDS.map((customField) => ({
...customField,
isCustom: true,
});
}
})),
);
Weiko marked this conversation as resolved.
Show resolved Hide resolved
}

async seedPeopleCustomFields(
Expand All @@ -289,11 +288,11 @@ export class DataSeedWorkspaceCommand extends CommandRunner {
workspaceId,
);

for (const customField of DEV_SEED_PERSON_CUSTOM_FIELDS) {
await this.fieldMetadataService.createOne({
await this.fieldMetadataService.createMany(
DEV_SEED_PERSON_CUSTOM_FIELDS.map((customField) => ({
...customField,
isCustom: true,
});
}
})),
);
}
}
Loading
Loading