Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo in Filename #9835

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

kimanikevin254
Copy link
Contributor

  • Rename mircosoft-apis-oauth-request-code.guard.ts to microsoft-apis-oauth-request-code.guard.ts
  • Update import statement in packages/twenty-server/src/engine/core-modules/auth/controllers/microsoft-apis-auth.controller.ts to reflect the updated filename.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed typo in Microsoft OAuth guard filename and corresponding import, but revealed a potential authentication issue in the guard implementation.

  • Critical: Unused strategy instance creation in microsoft-apis-oauth-request-code.guard.ts (line 52) could cause authentication failures as the new instance is created but never utilized
  • Renamed file from mircosoft-apis-oauth-request-code.guard.ts to microsoft-apis-oauth-request-code.guard.ts for correct spelling
  • Updated import path in microsoft-apis-auth.controller.ts to match new filename

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kimanikevin254 good catch! Just waiting to see if tests/typecheck passes and we can merge :)

@FelixMalfait FelixMalfait merged commit a8552a6 into twentyhq:main Jan 24, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants