Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

251 create top bar chips inside the command menu #9809

Merged
merged 12 commits into from
Jan 23, 2025

Conversation

bosiraphael
Copy link
Contributor

Closes #twentyhq/core-team-issues#251

Enregistrement.de.l.ecran.2025-01-23.a.11.32.31.mov

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the command menu's UI by adding context chips in the top bar and improving right drawer interactions with consistent title and icon displays across various components.

  • Added new CommandMenuContextChip component in /packages/twenty-front/src/modules/command-menu/components/CommandMenuContextChip.tsx for displaying contextual information with icons
  • Introduced commandMenuPageInfoState in /packages/twenty-front/src/modules/command-menu/states/commandMenuPageTitle.ts to manage page titles and icons
  • Added getWorkflowNodeIcon utility in /packages/twenty-front/src/modules/workflow/workflow-diagram/utils/getWorkflowNodeIcon.ts for consistent icon mapping
  • Enhanced right drawer interactions with standardized title and icon parameters across email, calendar, copilot, and workflow components
  • Improved workflow diagram components to display contextual information in command menu when interacting with nodes

20 file(s) reviewed, 17 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, some comments though

@bosiraphael bosiraphael requested a review from martmull January 23, 2025 12:51
Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bosiraphael bosiraphael merged commit 337b6a8 into main Jan 23, 2025
47 of 50 checks passed
@bosiraphael bosiraphael deleted the 251-create-top-bar-chips-inside-the-command-menu branch January 23, 2025 13:44
Copy link

sentry-io bot commented Jan 24, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Invalid value to persist: undefined for type : TEXT, type may not be implemented in usePersistField. /object/company/2d24bd54-af6e-4c40-b679-797f6ab... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create top bar chips inside the command menu
2 participants