-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
251 create top bar chips inside the command menu #9809
251 create top bar chips inside the command menu #9809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR enhances the command menu's UI by adding context chips in the top bar and improving right drawer interactions with consistent title and icon displays across various components.
- Added new
CommandMenuContextChip
component in/packages/twenty-front/src/modules/command-menu/components/CommandMenuContextChip.tsx
for displaying contextual information with icons - Introduced
commandMenuPageInfoState
in/packages/twenty-front/src/modules/command-menu/states/commandMenuPageTitle.ts
to manage page titles and icons - Added
getWorkflowNodeIcon
utility in/packages/twenty-front/src/modules/workflow/workflow-diagram/utils/getWorkflowNodeIcon.ts
for consistent icon mapping - Enhanced right drawer interactions with standardized title and icon parameters across email, calendar, copilot, and workflow components
- Improved workflow diagram components to display contextual information in command menu when interacting with nodes
20 file(s) reviewed, 17 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/command-menu/components/CommandMenuContextChip.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/command-menu/components/CommandMenuContextChip.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/command-menu/components/CommandMenuContextChip.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/command-menu/components/CommandMenuContextRecordChip.tsx
Outdated
Show resolved
Hide resolved
.../twenty-front/src/modules/activities/copilot/right-drawer/hooks/useOpenCopilotRightDrawer.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/right-drawer/hooks/useRightDrawer.ts
Show resolved
Hide resolved
...ont/src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasReadonlyEffect.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/workflow-diagram/utils/getWorkflowNodeIcon.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/workflow-diagram/utils/getWorkflowStepTypeIcon.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/workflow-steps/hooks/useCreateStep.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, some comments though
packages/twenty-front/src/modules/workflow/workflow-diagram/utils/getWorkflowStepTypeIcon.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/command-menu/components/CommandMenuContextRecordChip.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/workflow-diagram/utils/getWorkflowStepTypeIcon.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Closes #twentyhq/core-team-issues#251
Enregistrement.de.l.ecran.2025-01-23.a.11.32.31.mov