fix(UI/advanced-mode): collapse animation more smooth #9803
Conversation
Author: Julie Wu <[email protected]> Date: Wed Jan 22 19:08:02 2025 +0100
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the collapse animation smoothness in advanced settings by adjusting styling properties in the AdvancedSettingsWrapper and form components.
- Added
padding-bottomusing theme spacing inpackages/twenty-front/src/modules/settings/components/AdvancedSettingsWrapper.tsxto prevent content cutoff during animation - Modified
StyledAdvancedSettingsSectionInputWrapperinpackages/twenty-front/src/modules/settings/data-model/objects/forms/components/SettingsDataModelObjectAboutForm.tsxwithz-index: -1andposition: relativefor better stacking context - Removed
gapproperty fromStyledAdvancedSettingsSectionInputWrapperto eliminate spacing interference with animations
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| flex: 1; | ||
| z-index: -1; | ||
| position: relative; |
There was a problem hiding this comment.
logic: Setting z-index: -1 could cause issues with interactive elements inside this wrapper becoming unclickable if there are other elements with a higher z-index that overlap
| @@ -5,6 +5,7 @@ import { useRecoilValue } from 'recoil'; | |||
| import { AnimatedExpandableContainer, IconPoint, MAIN_COLORS } from 'twenty-ui'; | |||
|
|
|||
| const StyledAdvancedWrapper = styled.div` | |||
| padding-bottom: ${({ theme }) => theme.spacing(4)}; | |||
There was a problem hiding this comment.
@yukirine I think this might cause regressions somewhere else.
Could u verify all the places where this wrapper is being used we might have unwanted padding-bottom.
|
Also please mention the issue # in description :) thanks |
|
@ehconitin Hey |
Author: Julie Wu [email protected]
Date: Wed Jan 22 19:08:02 2025 +0100