feat: new relation resolver #9794
Conversation
magrinj
force-pushed
the
feat/new-relation-resolver
branch
from
200d488 to
056df8b
Compare
magrinj
force-pushed
the
feat/new-relation-resolver
branch
from
056df8b to
dbc5bb8
Compare
magrinj
force-pushed
the
feat/new-relation-resolver
branch
from
822b226 to
80398b9
Compare
magrinj
force-pushed
the
feat/new-relation-resolver
branch
from
0771d0b to
d733570
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a new relation resolver feature for managing workspace users, with a feature-flag controlled implementation for field metadata relations.
- Added new
FieldMetadataRelationServicein/packages/twenty-server/src/engine/metadata-modules/field-metadata/relation/field-metadata-relation.service.tsfor cached field metadata relation handling - Introduced
RelationDTOin/dtos/relation.dto.tsto define relation metadata structure with proper validation - Extended
IDataloadersinterface with newrelationLoaderindataloader.interface.tsfor efficient relation data loading - Added
IsNewRelationEnabledfeature flag (defaulting to false) for controlled rollout - Enhanced
FieldMetadataInterfacewith new relation-specific properties for defining field and object relationships
11 file(s) reviewed, 9 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-server/src/engine/dataloaders/dataloader.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/metadata-modules/field-metadata/dtos/relation.dto.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/metadata-modules/field-metadata/dtos/relation.dto.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.resolver.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.resolver.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.resolver.ts
Show resolved
Hide resolved
...erver/src/engine/metadata-modules/field-metadata/relation/field-metadata-relation.service.ts
Show resolved
Hide resolved
...erver/src/engine/metadata-modules/field-metadata/relation/field-metadata-relation.service.ts
Show resolved
Hide resolved
...erver/src/engine/metadata-modules/field-metadata/relation/field-metadata-relation.service.ts
Outdated
Show resolved
Hide resolved
| return { | ||
| sourceObjectMetadata: cleanObjectMetadata( | ||
| sourceObjectMetadata, | ||
| ) as ObjectMetadataEntity, |
There was a problem hiding this comment.
can we avoid these as ? maybe use Pick to defined the type of sourceObjectMetadata
There was a problem hiding this comment.
I've tried many things and we don't really have an easy way for now, I think a big refactor should be made to drop ObjectMetadataInterface and FieldMetadataInterface, as they were created at first to create "fake/standard" object from typescript file.
|
|
||
| import { ObjectMetadataItemWithFieldMaps } from 'src/engine/metadata-modules/types/object-metadata-item-with-field-maps'; | ||
|
|
||
| export const cleanObjectMetadata = ( |
There was a problem hiding this comment.
not a big fan of this util!
Initial naming is: ObjectMetadataItem (the one we know). ObjectMetadataItemWithFieldMaps (the one with fieldsById, fieldByName...). So could we add it next to the tooling to generate the maps and name it: parseObjectMetadataFromObjectMetadataWithFieldMaps(objectMetadataItemWithFieldMaps: ...)
There was a problem hiding this comment.
does not seem to be fixed!
...erver/src/engine/metadata-modules/field-metadata/relation/field-metadata-relation.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.resolver.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/dataloaders/dataloader.service.ts
Outdated
Show resolved
Hide resolved
Fix #240