Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import twenty-shared #9754

Merged
merged 10 commits into from
Jan 20, 2025
Merged

Fix import twenty-shared #9754

merged 10 commits into from
Jan 20, 2025

Conversation

charlesBochet
Copy link
Member

@charlesBochet charlesBochet commented Jan 20, 2025

In this PR:

  • removing rootDir / baseUrl from any tsconfig.json
  • we need to keep it in tsconfig.spec.json and also specify rootDir in jest.config.ts moduleMapper because of the way nx jest executor works (automatically moving back to root)
  • we need to explictly specify the depencies to twenty-shared / twenty-emails (built packages) in packages package.json to help nx understand dependencies

@@ -2,11 +2,13 @@
"extends": "./tsconfig.json",
"compilerOptions": {
"types": ["jest", "node"],
"rootDir": "../..",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we want to fix this, we will need to get rid of this nx nx/jest:jest runner

@charlesBochet charlesBochet merged commit e3f7cec into main Jan 20, 2025
47 checks passed
@charlesBochet charlesBochet deleted the fix-import-shared-3 branch January 20, 2025 22:10
@prastoin
Copy link
Contributor

👏 👏 👏 👏

charlesBochet pushed a commit that referenced this pull request Jan 22, 2025
Charles has done everything within
#9754
Last thing to be done is removing the custom module `path` configured in
the `tsconfig.json`

close twentyhq/core-team-issues#282
eliezer-rodrigues037 pushed a commit to mind-developer/kvoip-v2 that referenced this pull request Jan 23, 2025
Charles has done everything within
twentyhq#9754
Last thing to be done is removing the custom module `path` configured in
the `tsconfig.json`

close twentyhq/core-team-issues#282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants