bugfix: escape destroyed objects on workers #9719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies event handling to prevent foreign key constraint violations when destroying records by filtering out events without 'after' properties before sending them to audit logs and timeline activities.
- Fixed foreign key violation in
packages/twenty-server/src/engine/api/graphql/workspace-query-runner/listeners/entity-events-to-db.listener.tsby addingevent.properties.aftercheck - Incorrect type annotations in
handleDeleteandhandleDestroymethods usingObjectRecordUpdateEventinstead ofObjectRecordDeleteEvent - Unfiltered events still being sent to webhookQueueService could cause similar issues
- Root cause of foreign key constraint violation may need deeper investigation rather than event filtering
💡 (5/5) You can turn off certain types of comments like style here!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
pacyL2K19
force-pushed
the
bugfix/9358-exception-on-object-destroy
branch
from
8df2c41 to
2da33ca
Compare
...rver/src/engine/api/graphql/workspace-query-runner/listeners/entity-events-to-db.listener.ts
Outdated
Show resolved
Hide resolved
pacyL2K19
force-pushed
the
bugfix/9358-exception-on-object-destroy
branch
from
2da33ca to
9e515e8
Compare
FelixMalfait
approved these changes
Jan 22, 2025
pacyL2K19
force-pushed
the
bugfix/9358-exception-on-object-destroy
branch
from
6da3ae8 to
1017074
Compare
charlesBochet
approved these changes
Jan 23, 2025
Log |
DeepaPrasanna
pushed a commit
to DeepaPrasanna/twenty
that referenced
this pull request
Jan 27, 2025
# This PR - Fixes twentyhq#9358 @FelixMalfait please check this workaround --------- Co-authored-by: Félix Malfait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
@FelixMalfait please check this workaround