Fix multiworkspace mode returning inactive workspaces #9011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds workspace activation status filtering to the currentUser query, preventing users from accessing inactive workspaces in multi-workspace mode.
- Added
activationStatus: WorkspaceActivationStatus.ACTIVEfilter incurrentUserquery within/packages/twenty-server/src/engine/core-modules/user/user.resolver.ts - Modified workspace relation query to include activation status check in user resolver
- Ensures users can only switch between active workspaces in the UI dropdown
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Weiko
commented
Dec 10, 2024
|
Closing, let's do this on the FE side instead |
charlesBochet
deleted the
c--fix-multi-workspace-returning-inactive-workspaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently we return all the workspaces of a current user, including inactive ones.
This means when we switch to the other workspace through the UI, we are redirected to a workspace that is possibly in a broken state.
Before (with Toto being an INACTIVE workspace)
After
