Skip to content

Commit

Permalink
fix: more naming conventions
Browse files Browse the repository at this point in the history
  • Loading branch information
Nabhag8848 committed Aug 22, 2024
1 parent d4bc0f6 commit f88c600
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions packages/twenty-front/src/hooks/useDefaultHomePagePath.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const useDefaultHomePagePath = () => {
const currentUser = useRecoilValue(currentUserState);
const { activeObjectMetadataItems, alphaSortedActiveObjectMetadataItems } =
useFilteredObjectMetadataItems();
const { records } = usePrefetchedData(PrefetchKey.AllViews);
const { records: views } = usePrefetchedData(PrefetchKey.AllViews);
const { lastVisitedObjectMetadataItemId } =
useLastVisitedObjectMetadataItem();
let objectMetadata: {
Expand All @@ -27,7 +27,7 @@ export const useDefaultHomePagePath = () => {
return { defaultHomePagePath: AppPath.SignInUp };
}

const getActiveObjectMetadataMatchingId = (objectMetadataId: string) => {
const getActiveObjectMetadataItemMatchingId = (objectMetadataId: string) => {
return activeObjectMetadataItems.find(
(item) => item.id === objectMetadataId,
);
Expand All @@ -36,24 +36,26 @@ export const useDefaultHomePagePath = () => {
const getFirstObjectInfo = () => {
const [metadata] = alphaSortedActiveObjectMetadataItems;

const view = getViewMatchingObjectId(metadata.id);
const view = getViewMatchingObjectMetdataItemId(metadata.id);
return { metadata, view };
};

const getViewMatchingObjectId = (objectMetadataId: string) =>
records.find((view: any) => view?.objectMetadataId === objectMetadataId);
const getViewMatchingObjectMetdataItemId = (objectMetadataId: string) =>
views.find((view: any) => view?.objectMetadataId === objectMetadataId);

// last visited page exist in localstorage
if (!isNull(lastVisitedObjectMetadataItemId)) {
const lastVisitedMetadata = getActiveObjectMetadataMatchingId(
const lastVisitedObjectMetadataItem = getActiveObjectMetadataItemMatchingId(
lastVisitedObjectMetadataItemId,
);

// and last visited page is still active
if (!isUndefined(lastVisitedMetadata)) {
if (!isUndefined(lastVisitedObjectMetadataItem)) {
objectMetadata = {
view: getViewMatchingObjectId(lastVisitedObjectMetadataItemId),
metadata: lastVisitedMetadata,
view: getViewMatchingObjectMetdataItemId(
lastVisitedObjectMetadataItemId,
),
metadata: lastVisitedObjectMetadataItem,
};
} else {
// if not fallback to alphabetically first
Expand Down

0 comments on commit f88c600

Please sign in to comment.