Rename getWorkflowNodeIconKey

twentyhq · Jan 24, 2025 · a666e72 · a666e72
1 parent 87822af
commit a666e72
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 11 deletions.
diff --git a/.../src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasEditableEffect.tsx b/.../src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasEditableEffect.tsx
@@ -12,7 +12,7 @@ import {
   WorkflowDiagramNode,
   WorkflowDiagramStepNodeData,
 } from '@/workflow/workflow-diagram/types/WorkflowDiagram';
-import { getWorkflowNodeIcon } from '@/workflow/workflow-diagram/utils/getWorkflowNodeIcon';
+import { getWorkflowNodeIconKey } from '@/workflow/workflow-diagram/utils/getWorkflowNodeIconKey';
 import { OnSelectionChangeParams, useOnSelectionChange } from '@xyflow/react';
 import { useCallback } from 'react';
 import { useSetRecoilState } from 'recoil';
@@ -67,7 +67,7 @@ export const WorkflowDiagramCanvasEditableEffect = () => {
       setHotkeyScope(RightDrawerHotkeyScope.RightDrawer, { goto: false });
       openRightDrawer(RightDrawerPages.WorkflowStepEdit, {
         title: selectedNodeData.name,
-        Icon: getIcon(getWorkflowNodeIcon(selectedNodeData)),
+        Icon: getIcon(getWorkflowNodeIconKey(selectedNodeData)),
       });
     },
     [

diff --git a/.../src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasReadonlyEffect.tsx b/.../src/modules/workflow/workflow-diagram/components/WorkflowDiagramCanvasReadonlyEffect.tsx
@@ -9,7 +9,7 @@ import {
   WorkflowDiagramNode,
   WorkflowDiagramStepNodeData,
 } from '@/workflow/workflow-diagram/types/WorkflowDiagram';
-import { getWorkflowNodeIcon } from '@/workflow/workflow-diagram/utils/getWorkflowNodeIcon';
+import { getWorkflowNodeIconKey } from '@/workflow/workflow-diagram/utils/getWorkflowNodeIconKey';
 import { OnSelectionChangeParams, useOnSelectionChange } from '@xyflow/react';
 import { useCallback } from 'react';
 import { useSetRecoilState } from 'recoil';
@@ -39,7 +39,7 @@ export const WorkflowDiagramCanvasReadonlyEffect = () => {
       const selectedNodeData = selectedNode.data as WorkflowDiagramStepNodeData;
       openRightDrawer(RightDrawerPages.WorkflowStepView, {
         title: selectedNodeData.name,
-        Icon: getIcon(getWorkflowNodeIcon(selectedNodeData)),
+        Icon: getIcon(getWorkflowNodeIconKey(selectedNodeData)),
       });
     },
     [

diff --git a/...ty-front/src/modules/workflow/workflow-diagram/components/WorkflowDiagramStepNodeBase.tsx b/...ty-front/src/modules/workflow/workflow-diagram/components/WorkflowDiagramStepNodeBase.tsx
@@ -1,7 +1,7 @@
 import { assertUnreachable } from '@/workflow/utils/assertUnreachable';
 import { WorkflowDiagramBaseStepNode } from '@/workflow/workflow-diagram/components/WorkflowDiagramBaseStepNode';
 import { WorkflowDiagramStepNodeData } from '@/workflow/workflow-diagram/types/WorkflowDiagram';
-import { getWorkflowNodeIcon } from '@/workflow/workflow-diagram/utils/getWorkflowNodeIcon';
+import { getWorkflowNodeIconKey } from '@/workflow/workflow-diagram/utils/getWorkflowNodeIconKey';
 import { useTheme } from '@emotion/react';
 import styled from '@emotion/styled';
 import { useIcons } from 'twenty-ui';
@@ -24,7 +24,7 @@ export const WorkflowDiagramStepNodeBase = ({
 }) => {
   const theme = useTheme();
   const { getIcon } = useIcons();
-  const Icon = getIcon(getWorkflowNodeIcon(data));
+  const Icon = getIcon(getWorkflowNodeIconKey(data));
 
   const renderStepIcon = () => {
     switch (data.nodeType) {

diff --git a/...t/src/modules/workflow/workflow-diagram/utils/__tests__/getWorkflowVersionDiagram.test.ts b/...t/src/modules/workflow/workflow-diagram/utils/__tests__/getWorkflowVersionDiagram.test.ts
@@ -1,4 +1,3 @@
-import { IconPlus } from 'twenty-ui';
 import { getWorkflowVersionDiagram } from '../getWorkflowVersionDiagram';
 
 describe('getWorkflowVersionDiagram', () => {
@@ -58,7 +57,7 @@ describe('getWorkflowVersionDiagram', () => {
             name: 'Record is created',
             nodeType: 'trigger',
             triggerType: 'DATABASE_EVENT',
-            icon: IconPlus,
+            icon: 'IconPlus',
           },
           id: 'trigger',
           position: { x: 0, y: 0 },

diff --git a/...flow-diagram/utils/getWorkflowNodeIcon.ts → ...w-diagram/utils/getWorkflowNodeIconKey.ts b/...flow-diagram/utils/getWorkflowNodeIcon.ts → ...w-diagram/utils/getWorkflowNodeIconKey.ts
@@ -1,7 +1,7 @@
 import { WorkflowDiagramStepNodeData } from '@/workflow/workflow-diagram/types/WorkflowDiagram';
 import { getActionIcon } from '@/workflow/workflow-steps/workflow-actions/utils/getActionIcon';
 
-export const getWorkflowNodeIcon = (data: WorkflowDiagramStepNodeData) => {
+export const getWorkflowNodeIconKey = (data: WorkflowDiagramStepNodeData) => {
   switch (data.nodeType) {
     case 'trigger': {
       return data.icon;

diff --git a/packages/twenty-front/src/modules/workflow/workflow-steps/hooks/useCreateStep.ts b/packages/twenty-front/src/modules/workflow/workflow-steps/hooks/useCreateStep.ts
@@ -7,7 +7,7 @@ import {
   WorkflowWithCurrentVersion,
 } from '@/workflow/types/Workflow';
 import { workflowSelectedNodeState } from '@/workflow/workflow-diagram/states/workflowSelectedNodeState';
-import { getWorkflowNodeIcon } from '@/workflow/workflow-diagram/utils/getWorkflowNodeIcon';
+import { getWorkflowNodeIconKey } from '@/workflow/workflow-diagram/utils/getWorkflowNodeIconKey';
 import { useCreateWorkflowVersionStep } from '@/workflow/workflow-steps/hooks/useCreateWorkflowVersionStep';
 import { workflowCreateStepFromParentStepIdState } from '@/workflow/workflow-steps/states/workflowCreateStepFromParentStepIdState';
 import { useRecoilValue, useSetRecoilState } from 'recoil';
@@ -54,7 +54,7 @@ export const useCreateStep = ({
     setWorkflowSelectedNode(createdStep.id);
     setWorkflowLastCreatedStepId(createdStep.id);
 
-    const stepIcon = getWorkflowNodeIcon({
+    const stepIcon = getWorkflowNodeIconKey({
       nodeType: 'action',
       actionType: createdStep.type as WorkflowStepType,
       name: createdStep.name,