review(): from PR #8656 (#8870)

packages/twenty-front/src/modules/app/components/AppRouterProviders.tsx

@@ -22,6 +22,7 @@ import { WorkspaceProviderEffect } from '@/workspace/components/WorkspaceProvide
 import { StrictMode } from 'react';
 import { Outlet, useLocation } from 'react-router-dom';
 import { getPageTitleFromPath } from '~/utils/title-utils';
+import { PageFavicon } from '@/ui/utilities/page-favicon/components/PageFavicon';
 
 export const AppRouterProviders = () => {
   const { pathname } = useLocation();
@@ -49,6 +50,7 @@ export const AppRouterProviders = () => {
                               <PromiseRejectionEffect />
                               <GotoHotkeysEffectsProvider />
                               <PageTitle title={pageTitle} />
+                              <PageFavicon />
                               <Outlet />
                             </StrictMode>
                           </DialogManager>

packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpGlobalScopeForm.tsx

@@ -31,7 +31,7 @@ import { useReadCaptchaToken } from '@/captcha/hooks/useReadCaptchaToken';
 import { signInUpModeState } from '@/auth/states/signInUpModeState';
 import { useRequestFreshCaptchaToken } from '@/captcha/hooks/useRequestFreshCaptchaToken';
 import { useUrlManager } from '@/url-manager/hooks/useUrlManager';
-import { SignInUpMode } from '@/auth/types/signInUpMode.type';
+import { SignInUpMode } from '@/auth/types/signInUpMode';
 
 const StyledContentContainer = styled(motion.div)`
   margin-bottom: ${({ theme }) => theme.spacing(8)};

packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpPasswordField.tsx

@@ -5,7 +5,7 @@ import { motion } from 'framer-motion';
 import { StyledText } from 'twenty-ui';
 import { useTheme } from '@emotion/react';
 import { Form } from '@/auth/sign-in-up/hooks/useSignInUpForm';
-import { SignInUpMode } from '@/auth/types/signInUpMode.type';
+import { SignInUpMode } from '@/auth/types/signInUpMode';
 
 const StyledFullWidthMotionDiv = styled(motion.div)`
   width: 100%;

packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpWithCredentials.tsx

@@ -14,7 +14,7 @@ import { useState, useMemo } from 'react';
 import { captchaProviderState } from '@/client-config/states/captchaProviderState';
 import { isRequestingCaptchaTokenState } from '@/captcha/states/isRequestingCaptchaTokenState';
 import { FormProvider } from 'react-hook-form';
-import { SignInUpMode } from '@/auth/types/signInUpMode.type';
+import { SignInUpMode } from '@/auth/types/signInUpMode';
 
 const StyledForm = styled.form`
   align-items: center;

packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpWorkspaceScopeForm.tsx

@@ -4,15 +4,12 @@ import { useSignInUpForm } from '@/auth/sign-in-up/hooks/useSignInUpForm';
 import { SignInUpStep } from '@/auth/states/signInUpStepState';
 import { authProvidersState } from '@/client-config/states/authProvidersState';
 import styled from '@emotion/styled';
-import { useCallback, useEffect } from 'react';
 import { useRecoilState } from 'recoil';
 import { ActionLink, HorizontalSeparator } from 'twenty-ui';
 import { SignInUpWithGoogle } from '@/auth/sign-in-up/components/SignInUpWithGoogle';
 import { SignInUpWithMicrosoft } from '@/auth/sign-in-up/components/SignInUpWithMicrosoft';
 import { SignInUpWithSSO } from '@/auth/sign-in-up/components/SignInUpWithSSO';
 import { SignInUpWithCredentials } from '@/auth/sign-in-up/components/SignInUpWithCredentials';
-import { useLocation } from 'react-router-dom';
-import { isDefined } from '~/utils/isDefined';
 
 const StyledContentContainer = styled.div`
   margin-bottom: ${({ theme }) => theme.spacing(8)};
@@ -25,38 +22,7 @@ export const SignInUpWorkspaceScopeForm = () => {
   const { form } = useSignInUpForm();
   const { handleResetPassword } = useHandleResetPassword();
 
-  const { signInUpStep, continueWithEmail, continueWithCredentials } =
-    useSignInUp(form);
-  const location = useLocation();
-
-  const checkAuthProviders = useCallback(() => {
-    if (
-      signInUpStep === SignInUpStep.Init &&
-      !authProviders.google &&
-      !authProviders.microsoft &&
-      !authProviders.sso
-    ) {
-      return continueWithEmail();
-    }
-    const searchParams = new URLSearchParams(location.search);
-    const email = searchParams.get('email');
-    if (isDefined(email) && authProviders.password) {
-      return continueWithCredentials();
-    }
-  }, [
-    continueWithCredentials,
-    location.search,
-    authProviders.google,
-    authProviders.microsoft,
-    authProviders.password,
-    authProviders.sso,
-    continueWithEmail,
-    signInUpStep,
-  ]);
-
-  useEffect(() => {
-    checkAuthProviders();
-  }, [checkAuthProviders]);
+  const { signInUpStep } = useSignInUp(form);
 
   return (
     <>

packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpWorkspaceScopeFormEffect.tsx

@@ -0,0 +1,48 @@
+import { SignInUpStep } from '@/auth/states/signInUpStepState';
+import { isDefined } from '~/utils/isDefined';
+import { useSignInUp } from '@/auth/sign-in-up/hooks/useSignInUp';
+import { authProvidersState } from '@/client-config/states/authProvidersState';
+import { useSignInUpForm } from '@/auth/sign-in-up/hooks/useSignInUpForm';
+import { useRecoilState } from 'recoil';
+import { useCallback, useEffect } from 'react';
+
+const searchParams = new URLSearchParams(window.location.search);
+const email = searchParams.get('email');
+
+export const SignInUpWorkspaceScopeFormEffect = () => {
+  const [authProviders] = useRecoilState(authProvidersState);
+
+  const { form } = useSignInUpForm();
+
+  const { signInUpStep, continueWithEmail, continueWithCredentials } =
+    useSignInUp(form);
+
+  const checkAuthProviders = useCallback(() => {
+    if (
+      signInUpStep === SignInUpStep.Init &&
+      !authProviders.google &&
+      !authProviders.microsoft &&
+      !authProviders.sso
+    ) {
+      return continueWithEmail();
+    }
+
+    if (isDefined(email) && authProviders.password) {
+      return continueWithCredentials();
+    }
+  }, [
+    signInUpStep,
+    authProviders.google,
+    authProviders.microsoft,
+    authProviders.sso,
+    authProviders.password,
+    continueWithEmail,
+    continueWithCredentials,
+  ]);
+
+  useEffect(() => {
+    checkAuthProviders();
+  }, [checkAuthProviders]);
+
+  return <></>;
+};

packages/twenty-front/src/modules/auth/sign-in-up/hooks/useSignInUp.tsx

@@ -16,7 +16,7 @@ import {
 import { AppPath } from '@/types/AppPath';
 import { useAuth } from '../../hooks/useAuth';
 import { signInUpModeState } from '@/auth/states/signInUpModeState';
-import { SignInUpMode } from '@/auth/types/signInUpMode.type';
+import { SignInUpMode } from '@/auth/types/signInUpMode';
 
 export const useSignInUp = (form: UseFormReturn<Form>) => {
   const { enqueueSnackBar } = useSnackBar();

packages/twenty-front/src/modules/auth/sign-in-up/hooks/useSignInUpForm.ts

@@ -58,8 +58,10 @@ export const useSignInUpForm = () => {
   useEffect(() => {
     if (isDefined(prefilledEmail)) {
       form.setValue('email', prefilledEmail);
-    } else if (isDeveloperDefaultSignInPrefilled === true) {
-      form.setValue('email', '[email protected]');
+    }
+
+    if (isDeveloperDefaultSignInPrefilled === true) {
+      form.setValue('email', prefilledEmail ?? '[email protected]');
       form.setValue('password', 'Applecar2025');
     }
   }, [
@@ -68,5 +70,5 @@ export const useSignInUpForm = () => {
     prefilledEmail,
     location.search,
   ]);
-  return { form, validationSchema };
+  return { form: form, validationSchema };
 };

packages/twenty-front/src/modules/auth/states/signInUpModeState.ts

@@ -1,5 +1,5 @@
 import { createState } from 'twenty-ui';
-import { SignInUpMode } from '@/auth/types/signInUpMode.type';
+import { SignInUpMode } from '@/auth/types/signInUpMode';
 
 export const signInUpModeState = createState<SignInUpMode>({
   key: 'signInUpModeState',

packages/twenty-front/src/modules/settings/security/components/SettingsSSOIdentitiesProvidersListCard.tsx

@@ -14,7 +14,7 @@ import { useRecoilValue, useRecoilState } from 'recoil';
 import { IconKey } from 'twenty-ui';
 import { useListSsoIdentityProvidersByWorkspaceIdQuery } from '~/generated/graphql';
 import { SnackBarVariant } from '@/ui/feedback/snack-bar-manager/components/SnackBar';
-import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProviders.state';
+import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProvidersState';
 import { useSnackBar } from '@/ui/feedback/snack-bar-manager/hooks/useSnackBar';
 
 const StyledLink = styled(Link, {

packages/twenty-front/src/modules/settings/security/components/SettingsSSOIdentitiesProvidersListCardWrapper.tsx

@@ -6,7 +6,7 @@ import { getSettingsPagePath } from '@/settings/utils/getSettingsPagePath';
 import { SettingsPath } from '@/types/SettingsPath';
 import { SettingsListCard } from '@/settings/components/SettingsListCard';
 import { useNavigate } from 'react-router-dom';
-import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProviders.state';
+import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProvidersState';
 import { useRecoilValue } from 'recoil';
 
 export const SettingsSSOIdentitiesProvidersListCardWrapper = () => {

packages/twenty-front/src/modules/settings/security/components/SettingsSSOIdentityProviderRowRightContainer.tsx

@@ -1,7 +1,7 @@
 /* @license Enterprise */
 
 import { SettingsSecuritySSORowDropdownMenu } from '@/settings/security/components/SettingsSecuritySSORowDropdownMenu';
-import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProviders.state';
+import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProvidersState';
 import { getColorBySSOIdentityProviderStatus } from '@/settings/security/utils/getColorBySSOIdentityProviderStatus';
 import { Status } from 'twenty-ui';
 import styled from '@emotion/styled';

packages/twenty-front/src/modules/settings/security/components/SettingsSecurityOptionsList.tsx

@@ -14,7 +14,7 @@ import {
 import { useUpdateWorkspaceMutation } from '~/generated/graphql';
 import { AuthProviders } from '~/generated-metadata/graphql';
 import { capitalize } from '~/utils/string/capitalize';
-import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProviders.state';
+import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProvidersState';
 
 const StyledSettingsSecurityOptionsList = styled.div`
   display: flex;

packages/twenty-front/src/modules/settings/security/components/SettingsSecuritySSORowDropdownMenu.tsx

@@ -10,7 +10,7 @@ import {
 
 import { useDeleteSSOIdentityProvider } from '@/settings/security/hooks/useDeleteSSOIdentityProvider';
 import { useUpdateSSOIdentityProvider } from '@/settings/security/hooks/useUpdateSSOIdentityProvider';
-import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProviders.state';
+import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProvidersState';
 import { SnackBarVariant } from '@/ui/feedback/snack-bar-manager/components/SnackBar';
 import { useSnackBar } from '@/ui/feedback/snack-bar-manager/hooks/useSnackBar';
 import { Dropdown } from '@/ui/layout/dropdown/components/Dropdown';

packages/twenty-front/src/modules/settings/security/hooks/useCreateSSOIdentityProvider.ts

@@ -1,6 +1,6 @@
 /* @license Enterprise */
 
-import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProviders.state';
+import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProvidersState';
 import { useSetRecoilState } from 'recoil';
 import {
   CreateOidcIdentityProviderMutationVariables,

packages/twenty-front/src/modules/settings/security/hooks/useDeleteSSOIdentityProvider.ts

@@ -1,6 +1,6 @@
 /* @license Enterprise */
 
-import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProviders.state';
+import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProvidersState';
 import { useSetRecoilState } from 'recoil';
 import {
   DeleteSsoIdentityProviderMutationVariables,

packages/twenty-front/src/modules/settings/security/hooks/useUpdateSSOIdentityProvider.ts

@@ -1,6 +1,6 @@
 /* @license Enterprise */
 
-import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProviders.state';
+import { SSOIdentitiesProvidersState } from '@/settings/security/states/SSOIdentitiesProvidersState';
 import { useSetRecoilState } from 'recoil';
 import {
   EditSsoIdentityProviderMutationVariables,

packages/twenty-front/src/modules/ui/utilities/page-favicon/components/PageFavicon.tsx

@@ -0,0 +1,20 @@
+import { Helmet } from 'react-helmet-async';
+import { workspacePublicDataState } from '@/auth/states/workspacePublicDataState';
+import { useRecoilValue } from 'recoil';
+import { getImageAbsoluteURI } from '~/utils/image/getImageAbsoluteURI';
+
+export const PageFavicon = () => {
+  const workspacePublicData = useRecoilValue(workspacePublicDataState);
+
+  return (
+    <Helmet>
+      {workspacePublicData?.logo && (
+        <link
+          rel="icon"
+          type="image/x-icon"
+          href={getImageAbsoluteURI(workspacePublicData.logo)}
+        />
+      )}
+    </Helmet>
+  );
+};

packages/twenty-front/src/modules/workspace/components/WorkspaceProviderEffect.tsx

@@ -76,21 +76,5 @@ export const WorkspaceProviderEffect = () => {
     redirectToWorkspace,
   ]);
 
-  useEffect(() => {
-    try {
-      if (isDefined(workspacePublicData?.logo)) {
-        const link: HTMLLinkElement =
-          document.querySelector("link[rel*='icon']") ||
-          document.createElement('link');
-        link.rel = 'icon';
-        link.href = workspacePublicData.logo;
-        document.getElementsByTagName('head')[0].appendChild(link);
-      }
-    } catch (err) {
-      // eslint-disable-next-line no-console
-      console.error(err);
-    }
-  }, [workspacePublicData]);
-
   return <></>;
 };

packages/twenty-front/src/pages/auth/Invite.tsx

@@ -17,6 +17,7 @@ import {
 } from '~/generated/graphql';
 import { isDefined } from '~/utils/isDefined';
 import { currentUserState } from '@/auth/states/currentUserState';
+import { SignInUpWorkspaceScopeFormEffect } from '@/auth/sign-in-up/components/SignInUpWorkspaceScopeFormEffect';
 
 const StyledContentContainer = styled.div`
   margin-bottom: ${({ theme }) => theme.spacing(8)};
@@ -93,7 +94,10 @@ export const Invite = () => {
           <FooterNote />
         </>
       ) : (
-        <SignInUpWorkspaceScopeForm />
+        <>
+          <SignInUpWorkspaceScopeFormEffect />
+          <SignInUpWorkspaceScopeForm />
+        </>
       )}
     </>
   );

packages/twenty-front/src/pages/auth/SignInUp.tsx

@@ -17,6 +17,7 @@ import { isMultiWorkspaceEnabledState } from '@/client-config/states/isMultiWork
 import { useUrlManager } from '@/url-manager/hooks/useUrlManager';
 import { useMemo } from 'react';
 import { isDefined } from '~/utils/isDefined';
+import { SignInUpWorkspaceScopeFormEffect } from '@/auth/sign-in-up/components/SignInUpWorkspaceScopeFormEffect';
 
 export const SignInUp = () => {
   const { form } = useSignInUpForm();
@@ -43,7 +44,12 @@ export const SignInUp = () => {
       isDefined(workspacePublicData) &&
       (!isMultiWorkspaceEnabled || isTwentyWorkspaceSubdomain)
     ) {
-      return <SignInUpWorkspaceScopeForm />;
+      return (
+        <>
+          <SignInUpWorkspaceScopeFormEffect />
+          <SignInUpWorkspaceScopeForm />
+        </>
+      );
     }
 
     return <SignInUpGlobalScopeForm />;

packages/twenty-server/src/engine/core-modules/auth/auth.resolver.ts

@@ -38,7 +38,6 @@ import {
 } from 'src/engine/core-modules/auth/auth.exception';
 import { OriginHeader } from 'src/engine/decorators/auth/origin-header.decorator';
 import { AvailableWorkspaceOutput } from 'src/engine/core-modules/auth/dto/available-workspaces.output';
-import { workspaceValidator } from 'src/engine/core-modules/workspace/workspace.validate';
 import { DomainManagerService } from 'src/engine/core-modules/domain-manager/service/domain-manager.service';
 
 import { ChallengeInput } from './dto/challenge.input';
@@ -129,13 +128,7 @@ export class AuthResolver {
       targetWorkspaceSubdomain:
         this.domainManagerService.getWorkspaceSubdomainByOrigin(origin),
       fromSSO: false,
-      isAuthEnabled: workspaceValidator.isAuthEnabled(
-        'password',
-        new AuthException(
-          'Password auth is not enabled for this workspace',
-          AuthExceptionCode.OAUTH_ACCESS_DENIED,
-        ),
-      ),
+      authProvider: 'password',
     });
 
     const loginToken = await this.loginTokenService.generateLoginToken(

packages/twenty-server/src/engine/core-modules/auth/controllers/google-auth.controller.ts

@@ -18,13 +18,9 @@ import { GoogleProviderEnabledGuard } from 'src/engine/core-modules/auth/guards/
 import { AuthService } from 'src/engine/core-modules/auth/services/auth.service';
 import { GoogleRequest } from 'src/engine/core-modules/auth/strategies/google.auth.strategy';
 import { LoginTokenService } from 'src/engine/core-modules/auth/token/services/login-token.service';
-import {
-  AuthException,
-  AuthExceptionCode,
-} from 'src/engine/core-modules/auth/auth.exception';
+import { AuthException } from 'src/engine/core-modules/auth/auth.exception';
 import { EnvironmentService } from 'src/engine/core-modules/environment/environment.service';
 import { DomainManagerService } from 'src/engine/core-modules/domain-manager/service/domain-manager.service';
-import { workspaceValidator } from 'src/engine/core-modules/workspace/workspace.validate';
 import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
 
 @Controller('auth/google')
@@ -70,13 +66,7 @@ export class GoogleAuthController {
         workspacePersonalInviteToken,
         targetWorkspaceSubdomain,
         fromSSO: true,
-        isAuthEnabled: workspaceValidator.isAuthEnabled(
-          'google',
-          new AuthException(
-            'Google auth is not enabled for this workspace',
-            AuthExceptionCode.OAUTH_ACCESS_DENIED,
-          ),
-        ),
+        isAuthEnabled: 'google',
       };
 
       if (