Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH can be replaced by POST with X-HTTP-Method-Override PATCH #188

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

YassinHajaj
Copy link
Contributor

PATCH can be replaced by POST with X-HTTP-Method-Override PATCH

Adding the request body's content with application/offset+octet-stream
PATCH can be replaced by POST with X-HTTP-Method-Override PATCH
@YassinHajaj
Copy link
Contributor Author

I'll fix the failing linter problem

@YassinHajaj
Copy link
Contributor Author

Ok, it seems the linter is failing for months now.

@Acconut
Copy link
Member

Acconut commented Feb 14, 2023

Thank you, but I am wondering if this could also be achieved without copying the definition of the PATCH method? This duplicates a lot of code, which I would like to avoid.

@YassinHajaj
Copy link
Contributor Author

Sure, I'll look into it.
Have to read what's possible from the OpenAPI spec

@Acconut
Copy link
Member

Acconut commented Feb 15, 2023

Great, let me know if you find something suitable!

@Acconut
Copy link
Member

Acconut commented Jul 17, 2023

@YassinHajaj Did you have any success with this so far?

@YassinHajaj
Copy link
Contributor Author

Hey @Acconut ,

No, I'm sorry.
And I'm afraid I'll not have time in the coming months, I've been pulled by other things.
Hope it's ok.

@Acconut
Copy link
Member

Acconut commented Jul 19, 2023

That you for the headsup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants