Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@tus/s3-store: fix part number increment #689

Merged
merged 6 commits into from
Dec 23, 2024
Merged

Conversation

fenos
Copy link
Collaborator

@fenos fenos commented Dec 19, 2024

Fixes #686
Fixes #688
Fixes #664

Caused by a regression

This PR correctly increment the part number

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: d0fdc37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tus/s3-store Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fenos
Copy link
Collaborator Author

fenos commented Dec 19, 2024

@Murderlon feel free to take over this PR

@Murderlon Murderlon changed the title s3-store: Fix part upload number @tus/s3-store: fix part number increment Dec 21, 2024
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Added a test to confirm.

Also I can't believe a change of formatters caused this regression but honestly a test should have caught it 🤔

@Murderlon Murderlon merged commit 32d847d into main Dec 23, 2024
3 checks passed
@Murderlon Murderlon deleted the s3-store/fix-part-upload branch December 23, 2024 09:52
@fenos
Copy link
Collaborator Author

fenos commented Dec 23, 2024

Thanks a lot @Murderlon 🙏

Murderlon added a commit to netdown/tus-node-server that referenced this pull request Jan 20, 2025
* main: (59 commits)
  Replace demo folder with StackBlitz (tus#704)
  @tus/gcs-store: correctly pass content type (tus#702)
  @tus/s3-store: fix zero byte files (tus#700)
  Update package-lock.json
  [ci] release (tus#696)
  fix: handling consistent cancellation across stream and locks (tus#699)
  @tus/s3-store: Change private modifier into protected (tus#698)
  Create funding-manifest-urls
  Bump @aws-sdk/client-s3 from 3.703.0 to 3.717.0 (tus#695)
  Bump mocha from 10.4.0 to 11.0.1 (tus#693)
  Bump @biomejs/biome from 1.9.2 to 1.9.4 (tus#694)
  [ci] release (tus#690)
  Bump @aws-sdk/client-s3 from 3.701.0 to 3.703.0 (tus#685)
  @tus/s3-store: fix part number increment (tus#689)
  Revert "Bump rimraf from 3.0.2 to 6.0.1 (tus#681)"
  Bump @aws-sdk/client-s3 from 3.682.0 to 3.701.0 (tus#683)
  Bump @changesets/cli from 2.27.9 to 2.27.10 (tus#682)
  Bump rimraf from 3.0.2 to 6.0.1 (tus#681)
  Bump @types/node from 20.11.5 to 22.10.1 (tus#679)
  Ignore JSON for Biome formatting
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants