Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GridFS support #526

Closed
wants to merge 23 commits into from
Closed

Add GridFS support #526

wants to merge 23 commits into from

Conversation

spencerjibz
Copy link

@spencerjibz spencerjibz commented Dec 4, 2023

Background

Hi there, I have used gridFS for a while now, so recently thought might as well build a tus-store for it, I know there was a related issue to this back in 2016.

Implementation Details

  • Extended MongoDB's gridfs write stream to support updating existing files. (can contribute this back to the mongo repo later).
  • Added a config Store for usage, internally used by the store package, but can also be used separately with other stores(FileStore).
  • Modified the demos to include the new store.
  • Added tests for the new store and also a MongoDB-in-memory server for tests and CI
  • Added e2e test for the gridfs-store

Let me know if there are any changes you'd like me to make.

@spencerjibz spencerjibz marked this pull request as draft December 4, 2023 09:42
@spencerjibz spencerjibz marked this pull request as ready for review December 4, 2023 09:42
@spencerjibz spencerjibz marked this pull request as draft December 5, 2023 09:02
@spencerjibz
Copy link
Author

spencerjibz commented Dec 5, 2023

Just realised, l need to add e2e tests for the new store.

@spencerjibz spencerjibz marked this pull request as ready for review December 5, 2023 18:51
@Murderlon
Copy link
Member

Thanks a lot for the massive contribution. Because this is a big PR, it will require a deep dive review for which I don't have time now but I'll come back to it.

@Murderlon
Copy link
Member

Sorry for the enormous delay. I really appreciate you taking the time to contribute. After thinking about it, I don't think taking on this maintenance burden and complexity is worth it for such a niche store. However I'll happily link this in the readme as a community plugin. Would you be interested in that?

@Murderlon Murderlon closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants