-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Nyrkiö on PRs and clickbench #959
base: main
Are you sure you want to change the base?
Conversation
- uses: actions/checkout@v3 | ||
- name: Bench | ||
run: cargo bench | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added quite a lot of benchmarks the past 2 weeks and this now takes 7 minutes or more, so I suggest to separate.
No need for Nyrkiö to do that. Just a suggestion in general.
This comment was marked as resolved.
This comment was marked as resolved.
TL;DR: Suggest to merge this version. Longer term can add support for outside contributors on the nyrkio.com side. Ok I did some reading and there are 3 options:
|
26165fb
to
16888a4
Compare
Set pvalue and threshold from workflow
- Rename push_only.yml workflow to rust_perf.yml - Move the 'bench' task from rust.yml to rust_perf.yml - More Nyrkio configuration options exposed: Team support (everyone in gh/tursodatabase can access Nyrkiö) Public results Alerting options: Comment on PR, if change detected, don't fail task
This allows PRs to succeed regardless of who submitted them. Feels friendlier that way.
16888a4
to
24839e6
Compare
- Rename push_only.yml workflow to rust_perf.yml - Move the 'bench' task from rust.yml to rust_perf.yml - More Nyrkio configuration options exposed: Team support (everyone in gh/tursodatabase can access Nyrkiö) Public results Alerting options: Comment on PR, if change detected, don't fail task
Sorry about the mess above. I accidentally pushed some different branch when I started to work on the clickbennch integration. But now everything should be good. |
Team support (everyone in gh/tursodatabase can access Nyrkiö)
Public results
Alerting options: Comment on PR, if change detected, don't fail task