Will Fox #15
Open
Will Fox #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally I thought this IC went well, slow but well.
I got stalled on the #register_candidate method early on actually. I was initializing the new candidate objects in my test instead of implementing that code INSIDE the #register_candidate method. That idea still trips me up a bit, initializing an object from one class within a method from a different class.
I was able to accomplish the iterating using .each which is my preferred enumerable. I should have used the .times method to register my 'vote_for' command methods in the #vote_counts test, but I forgot the correct syntax and ran out of time to look it up. Not a big deal, but all of that repetition makes for a congested block of code.