fix: ignore error messages from all error types #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdecat
changed the title
ParthaI
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Hello @pdecat,
The changes in this PR make sense to me!
However, could you please clean up the unnecessary log statements (Trace/Debug level)? I believe keeping just one debug-level log statement before the return would be sufficient.
Thanks!
|
Thanks @ParthaI, done! |
ParthaI
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets the branch of #476 to allow ignoring error messages from more APIs (e.g. Redis).
See #476 (comment)