Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] MentorshipDetails page #97

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

[WIP] MentorshipDetails page #97

wants to merge 18 commits into from

Conversation

sabine-mansour
Copy link

@sabine-mansour sabine-mansour commented Aug 29, 2022

What Github issue does this PR relate to?

Close #70
Close #16

Created Relationship API
Created Relationship Page
Created Relationship Form: Mentor and/or mentee can add their notes/goals on the current

This step is when there is an on-going mentoring (after the mentor accepted mentee's request)

What should the reviewer know?

Please be aware that there is an error preventing the page to load properly

@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for tupu-app ready!

Name Link
🔨 Latest commit 259cf73
🔍 Latest deploy log https://app.netlify.com/sites/tupu-app/deploys/6396556742695500087f30ec
😎 Deploy Preview https://deploy-preview-97--tupu-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sabine-mansour
Copy link
Author

@lorepirri - Here is the draft pull request to my task.
I can see all checks have failed

@tsg
Copy link
Member

tsg commented Aug 29, 2022

@sabine-mansour I think it's because there are couple of compilation errors, see here in the Netlify build log: https://app.netlify.com/sites/tupu-app/deploys/630cdb01a72cff0008f00c45#L134-L141 It's linked in the comment from Netlify.

@lorepirri
Copy link
Contributor

@lorepirri - Here is the draft pull request to my task. I can see all checks have failed

Hi @sabine-mansour, try to make it run commenting out the not defined things highlighted in the log mentioned by Tudor (thanks @tsg ), so than we can proceed by looking at what was not yet working

@lorepirri
Copy link
Contributor

Close #70

@lorepirri lorepirri linked an issue Aug 29, 2022 that may be closed by this pull request
@lorepirri lorepirri changed the title Task16 sabine Mentorship Details page [Task16 sabine] Aug 29, 2022
@lorepirri lorepirri changed the title Mentorship Details page [Task16 sabine] MentorshipDetails page Oct 16, 2022
@lorepirri lorepirri changed the title MentorshipDetails page WIP MentorshipDetails page Jan 5, 2023
@lorepirri lorepirri changed the title WIP MentorshipDetails page [WIP] MentorshipDetails page Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MentorshipDetails page Profile: Mentor Pressing on Mentee's Name/ Mentee Pressing on Mentor's Name
3 participants