Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile: Mentor Pressing on Mentee's Name/ Mentee Pressing on Mentor's Name #16

Open
sabine-mansour opened this issue Feb 9, 2022 · 5 comments · May be fixed by #97
Open

Profile: Mentor Pressing on Mentee's Name/ Mentee Pressing on Mentor's Name #16

sabine-mansour opened this issue Feb 9, 2022 · 5 comments · May be fixed by #97
Assignees

Comments

@sabine-mansour
Copy link

When a mentor is pressing on the name of one of his/her mentees a window will open. This window will have tabs for:
-Goals
-Notes
-Close Mentorship
--Button: Close Mentorship
--Edit Box: Some words about the mentorship and some take away for yourself.
--Edit Box: Feedback for Tupu(write some words about how the mentorship went and if there is something Tupu can support you for your next mentorship)

Just the same for when a mentee is pressing on the name of one of his mentors. As a mentee can also have several: One Time Mentorship

Whimsical:Not added yet. TO BE DONE

@sabine-mansour sabine-mansour self-assigned this Feb 9, 2022
@sabine-mansour
Copy link
Author

Hi @tsg @Rambazamba6
Small question: Would you like the window to open on a new page or on a modal over the current page?

@ClaraPapaya I believe we have worked on something similar with CareerFoundry. If you would like we could work together on this task. One can work on the mentor and the other one with the mentees.

@Rambazamba6
Copy link
Contributor

Rambazamba6 commented Feb 10, 2022

Hi @sabine-mansour,

good thing you've asked, as I've rethought the process and also made the wire framing.
I thought that when clicking on the name of the mentee, it's better to open a new page with the details of the mentee + the possibility for mentor to introduce the Goals and Notes.
At the end of the page, there will be the dropdown button to change the Mentorship Status to Finish/Long Term Mentorship.
Mentor-Mentee

When changing the Mentorship Status to Finish, a window will open over the current page where the mentor can write some notes about the mentorship and send feedback to Tupu.

Test

Please let me know if now it's clear.

@tsg
Copy link
Member

tsg commented Feb 10, 2022

I like the wireframes from @Rambazamba6! I wanted to say that modals have the disadvantage that you can't link to them, and they are also usually more complex to maintain in the code as well, so I'd say we generally minimize their use. But the way it's proposed in the comment above, I think it makes sense.

@sabine-mansour
Copy link
Author

Thanks @Rambazamba6! It makes sense
@tsg good to know!

I will try to get started with this task then! :)

@ClaraPapaya ClaraPapaya self-assigned this Feb 28, 2022
@ClaraPapaya
Copy link
Contributor

@sabine-mansour
As we discussed yesterday, I made some user stories for the mentor for this issue, please find a doc here (I left it as a doc so we can both make changes).

I also created a branch called issue16 where I tried some steps for my user story 1. I copied a lot from what Tudor already did for the MentorList etc. so it's just a start and not perfect yet. Hope this works for now locally and makes sense :)

@ClaraPapaya ClaraPapaya mentioned this issue Mar 14, 2022
1 task
@lorepirri lorepirri linked a pull request Dec 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants