Several bugs fixed, Typos corrected, Docker Supported #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a few days of use, I've noticed a few minor issues. I've also provided a Dockerfile that makes it very easy to use this repository. Hopefully this pull request will greatly improve the accessibility of dev-kit.
I tested this version with your demo
It works on all of them except for the "OpenLABEL to nuScenes", but I found the same error on the old repo, so I do not think this pull request introduce any new bugs.
Note: you should delete the /docker folder and the dockerfile in it which was a draft. I didn't remove it by mistake, so please delete it when you merge this pr.